D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

"Friedrich W. H. Kossebau" <[email protected]> Thu, 20 Feb 2020 23:44:32 +0000

Newsgroups	gmane.comp.kde.devel.frameworks,gmane.comp.kde.devel.kwrite
Message-ID	<[email protected]>

kossebau added inline comments.

INLINE COMMENTS

> kateviewhelpers.cpp:1963
>                              const int s = qMin(m_iconAreaWidth * devicePixelRatioF(), h * devicePixelRatioF()) - 2;
> -                            px_mark = px_mark.scaled(s, s, Qt::KeepAspectRatio, Qt::SmoothTransformation);
> +                            QPixmap px_mark = markIcon.pixmap(s);
> +                            px_mark.setDevicePixelRatio(devicePixelRatioF());

Possibly `QIcon::paint()` might be also working here as wanted? Needs someone with HiDPI to check if all things behave as wanted. The old code with all the `devicePixelRatioF()` made me change not too much here.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann