D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

Anthony Fieroni <[email protected]> Sat, 22 Feb 2020 08:34:43 +0000

Newsgroups	gmane.comp.kde.devel.kwrite,gmane.comp.kde.devel.frameworks
Message-ID	<[email protected]>

anthonyfieroni added inline comments.

INLINE COMMENTS

> katedocument.h:86
>  class KTEXTEDITOR_EXPORT KTextEditor::DocumentPrivate : public KTextEditor::Document,
> -                                                        public KTextEditor::MarkInterface,
> +                                                        public KTextEditor::MarkInterfaceV2,
>                                                          public KTextEditor::ModificationInterface,

Why private class is exported, changing parent of an exported class is BIC.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop
Cc: anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars