D28039: optimize dynamic regex matching

Dominik Haumann <[email protected]> Fri, 13 Mar 2020 21:48:30 +0000

Newsgroups	gmane.comp.kde.devel.frameworks,gmane.comp.kde.devel.kwrite
Message-ID	<[email protected]>

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I guess this is OK, but the concept of a "skip offset" is a bit fuzzy to me.

INLINE COMMENTS

> rule_p.h:126
> +
> +protected:
> +    bool m_dynamic = false;

I dislike this protected hack :-)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28039

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann