Re: Changes to "schema" aka "color theme" handling
Andreas Cord-Landwehr <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwrite |
|---|---|
| Message-ID | <3003883.5fSG56mABF@behemoth> |
Hi, that's a nice idea! And I would give bonus points, if the full SPDX-License-Identifier syntax with "OR", "AND", braces and "WITH" operators would be supported :D The detailed specification is here [1] ;) Cheers, Andreas [1] https://spdx.github.io/spdx-spec/appendix-IV-SPDX-license-expressions/[1] On Sonntag, 13. September 2020 16:44:23 CEST Dominik Haumann wrote: > Hi Christoph, > > very well done :) > > I btw just got another idea: > We could add things like SPDX-FileCopyrightText or SPDX-LicenseIdentifier > etc. to either Alerts.xml or Doxygen.xml. Then we'd have nice highlighting > for this as well. > > Best regards > Dominik > > > > > Christoph Cullmann <[email protected]> schrieb am So., 13. Sep. 2020, > > 15:26: > > On 2020-09-10 22:28, Christoph Cullmann wrote: > > > Hi, > > > > > > https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/21 > > > > > > should now work. > > > > This got now merged. > > > > I did some further code cleanups afterwards and some more internal > > "schema" => "theme" renamings. > > > > More testing + fixes + new themes are appreciated .P > > > > For more details, I wrote > > https://kate-editor.org/post/2020/2020-09-13-kate-color-themes-5.75/ > > > > Greetings > > Christoph > > > > > If somebody could give this some testing, that would be appreciated. > > > > > > You need latest master syntax-highlighting due to some bugfixing + the > > > branch of > > > that request. > > > > > > Feedback (+ fixes) appreciated. > > > > > > Greetings > > > Christoph > > > > > > On 2020-09-07 23:16, Christoph Cullmann wrote: > > >> Hi, > > >> > > >> the first part of this stuff is now merged. > > >> > > >> In > > >> > > >> https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/21 > > >> > > >> I am working on completely removing the old schema stuff and only > > >> using KTextEditor::Theme > > >> as basis for the coloring. > > >> > > >> The actual usage is already OK, the remaining missing pieces is the > > >> saving of the configuration > > >> as JSON files. > > >> > > >> Any help (and testing) welcome! > > >> > > >> Just ping me in the merge request. > > >> > > >> Greetings > > >> Christoph > > >> > > >> On 2020-09-02 22:24, Christoph Cullmann wrote: > > >>> KTextEditor uses since long the KSyntaxHighlighting framework to > > >>> provide the highlighting instead it's old own code. > > >>> > > >>> But for the coloring, we bypassed all stuff provided by this > > >>> framework. > > >>> > > >>> For the frameworks release in October I want to change this and > > >>> switch > > >>> over to the color themes as provided by KSyntaxHighlighting (but > > >>> still > > >>> allow to configure them like now via the GUI and provide own ones in > > >>> the "old" style). > > >>> > > >>> The matching merge request is: > > >>> > > >>> https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/20 > > >>> > > >>> If you have some time to test this, feel welcome! > > >>> > > >>> Beside that, it would make sense to provide some more bundled themes > > >>> (if available as MIT licensed stuff), see this development issue for > > >>> some potential candidates: > > >>> > > >>> https://invent.kde.org/frameworks/syntax-highlighting/-/issues/2 > > >>> > > >>> Contributors welcome ;=) > > >>> > > >>> The stuff must end up as JSON file in