Re: bring speed back into KConfig

On Saturday 19 April 2008, Jakub Stachowski wrote:
> - Whole BufferFragment class got dumped into kconfigini_p.h and is now part of 
> KConfigIniBackend

You know that you don't -have- to put all the code inside the parent class, right?

I think this would be more readable:

class KConfigIniBackend : public KConfigBackend
{
public:
    class BufferFragment;
    [... existing contents...]
};

and anywhere you want (_p.h or .cpp) :

class KConfigIniBackend::BufferFragment 
{ 
public:
    [...implementation, with all methods inline, like you have currently...]
};

Otherwise human-readability of the KConfigIniBackend class becomes difficult :)

Great patch, otherwise.

-- 
David Faure, [email protected], sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).