Re: please review

On Sunday 12 March 2006 15:30, Jens Herden wrote:
> > That sounds good and is also an improvement, I will try to make it.
>
> I did and the result is attached. Unfortunately the positioning of
> the cursor does work only for local files, because the Kate part does
> open remote files async and the file is not yet available when I set
> the cursor.

Yes, there is a solution in QuantaDoc to solve this problem, but I don't 
think it is critical here.

> I would not spend more time on this issue, if the patch is OK I would
> like to commit it?

I have one suggestion: don't check for the exitance of viewCursorIf. If 
that is not available for the editor we can safely say that we don't 
support that editor because it doesn't implement the *basic* 
KTextEditor interfaces and Quanta will not work at all.

Andras
-- 
Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org

_______________________________________________
quanta-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/quanta-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQBEFDACTQdfac6L/08RAlkYAJoCDLJy7nuIOH4j9Q8OtkQkmGMY5QCguxdP
fyxAUFfkU7YHj204uDLkJdg=
=my1k
-----END PGP SIGNATURE-----