Re: Upload-Plugin

Hi,

Thanks for your review.
I finally committed the upload-plugin to svn. It's not finished, but
already in a working state.

New/Changed:
- A Upload-Profile-FilesView - that display the server-side files - as
Quanta3 did it
  Quanta3 hat an individual dock for every profile, I packed it into
one dock with a ComboBox
  above to select the profile. (using View -> Add Tool View it is
posible to open more views)
- added "mark as uploaded" feature (as in Quanta3)
- Implemented Quick Upload (as in Quanta3)
  (one difference: it doesn't upload unchanged files)
- Layout of the UploadDialog improved
- To display the progress I used now a KProgressDialog - instead of
the ProgressBar below
  the UploadDialog. When doing a Quick-Upload the UploadDialog isn't
needed at all.

ToDo:
- ProfilesFileTree: activated not fired on double click, only when
return is pressed
- Show ProfileFileTree only when there is at least one project with an
upload profile
- show Upload-context-menu only when there is at least one upload profile
- use Log-Toolview to output which files have been uploaded
- UploadDialog: Context-Menu with All, Modified, Invert
- when you create a new profile and that is the only one, the "Use as
default profile" should be ticked
- ProfilesFileTree: show profiles (in the combo-box) as tree
- Upload-Menu-Item in Menubar (Project)
- display the Upload & Quick-Upload context menu in Document-Context
(didn't get this working
  using requestContextMenuActions)
- Improve GUI for editing the Profile-Url: Use a graphical
dir-selector (useful for the path)
  any ideas on this?


> Of course I couldn't read it line by line, and I don't want to do. For the code, I have the following (small) comments:
> - please add doxygen documentation for the headers. I know it is not the case for all the other plugins, but i'd like to set this as a requirement for new code that is added.
I added them. (for classes and public functions)
Is that enough? If not - what should be added?

> - for kDebug() Quanta has the "24000" debug area allocated (kDebug(24000)). But as now KDE supports per-project debug area setting in the CMakeFile.txt, this is not a big issue. I'll add that one, so you can keep the kDebug() lines as they are. :)
I added "add_definitions ( -DKDE_DEFAULT_DEBUG_AREA=24000 )" to
upload/CMakeLists.txt.
Was this the correct place?

> Regarding the functionality, I noticed so far the following issues (I realize that they would be too much to ask from a first implementation, but these are what came to my mind, in random order):
See the above todo-list :D

> - use KWallet for storing the password
Isn't KWalled used automatically by KIO? For my tests with a
fish-server KWallet stored
the password.

> - uploading the whole project or a folder seems to not work, it gives an error like:
> Could not write to file /data/development/quanta/upload/bin/akte.part
> (bin/akte is what it is trying to upload). Probably does not create the "bin" folder on the upload server.
Should be fixed now (I found a few bugs)

> - do you plan to work on this (or other parts of Quanta) in the future? I hope yes. :)
Yes - I would like to work on Quanta! I hope I find enough free-time...
For now I have enough to do with this plugin, but later I plan to work
on other parts too.


greetings,
Niko