Re: Review Request: Fix missing pointer indiicating the current line while debugging with xdebug

"Milian Wolff" <[email protected]> Sun, 28 Aug 2011 12:54:55 -0000
Newsgroups gmane.comp.kde.devel.quanta
Message-ID <[email protected]> 
--===============3178574157416660197==
Content-Type: multipart/alternative;
	boundary="===============8635721331080619318=="

--===============8635721331080619318==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102456/#review6097
-----------------------------------------------------------

Ship it!


looks good to me

- Milian


On Aug. 27, 2011, 1:48 p.m., Florian Zumkeller-Quast wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102456/
> -----------------------------------------------------------
> =

> (Updated Aug. 27, 2011, 1:48 p.m.)
> =

> =

> Review request for KDevelop and Quanta.
> =

> =

> Summary
> -------
> =

> Fixes the missing pointer on the left side when stepping/debugging with x=
debug
> =

> =

> This addresses bug 271929.
>     http://bugs.kde.org/show_bug.cgi?id=3D271929
> =

> =

> Diffs
> -----
> =

>   debuggers/xdebug/connection.h 3f12413 =

>   debuggers/xdebug/connection.cpp 4421b8a =

>   debuggers/xdebug/debugsession.cpp b051453 =

> =

> Diff: http://git.reviewboard.kde.org/r/102456/diff
> =

> =

> Testing
> -------
> =

> Test with a little PHP script - it did work.
> =

> =

> Thanks,
> =

> Florian
> =

>


--===============8635721331080619318==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable




<html>
 <body>
  <div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"http://git.reviewboard.kde.org/r/102456/">http://git.revie=
wboard.kde.org/r/102456/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good=
 to me</pre>
 <br />







<p>- Milian</p>


<br />
<p>On August 27th, 2011, 1:48 p.m., Florian Zumkeller-Quast wrote:</p>






<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>


<p style=3D"color: grey;"><i>Updated Aug. 27, 2011, 1:48 p.m.</i></p>




<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Fixes the missing pointer on the left side when stepping/deb=
ugging with xdebug</pre>
  </td>
 </tr>
</table>


<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Test with a little PHP script - it did work.</pre>
  </td>
 </tr>
</table>



<div style=3D"margin-top: 1.5em;">
 <b style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href=3D"http://bugs.kde.org/show_bug.cgi?id=3D271929">271929</a>


</div>


<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 </h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>debuggers/xdebug/connection.h <span style=3D"color: grey">(3f12413)</s=
pan></li>

 <li>debuggers/xdebug/connection.cpp <span style=3D"color: grey">(4421b8a)<=
/span></li>

 <li>debuggers/xdebug/debugsession.cpp <span style=3D"color: grey">(b051453=
)</span></li>

</ul>

<p><a href=3D"http://git.reviewboard.kde.org/r/102456/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============8635721331080619318==--

--===============3178574157416660197==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
quanta-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/quanta-devel

--===============3178574157416660197==--