Re: Review Request: Fix compile break of quanta
"Milian Wolff" <[email protected]> Thu, 10 Nov 2011 14:18:22 -0000
| Newsgroups | gmane.comp.kde.devel.quanta |
|---|---|
| Message-ID | <[email protected]> |
--===============3446535247089146494==
Content-Type: multipart/alternative;
boundary="===============4156075558380152953=="
--===============4156075558380152953==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103106/#review8100
-----------------------------------------------------------
Ship it!
commit is fine besides a few style issues, put the &,* always adjacent to t=
he typename for consistency please.
if you have commit rights, please fix this before pushing.
otherwise send me this patch as created by "git format-patch" - if possible=
with the style issue fixed. otherwise I'll do that.
thanks =
languages/xml/formatter/formatterplugin.cpp
<http://git.reviewboard.kde.org/r/103106/#comment6962>
please put the & adjacent to the typename for consistency
languages/xml/formatter/formatterplugin.cpp
<http://git.reviewboard.kde.org/r/103106/#comment6963>
also here, & adjacent to the typename please
plugins/phpformatter/formatterplugin.h
<http://git.reviewboard.kde.org/r/103106/#comment6964>
again, please & adjacent to typename
plugins/phpformatter/formatterplugin.cpp
<http://git.reviewboard.kde.org/r/103106/#comment6965>
& again... :)
plugins/phpformatter/formatterplugin.cpp
<http://git.reviewboard.kde.org/r/103106/#comment6966>
& again... :)
- Milian Wolff
On Nov. 10, 2011, 12:05 p.m., Florian Zumkeller-Quast wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103106/
> -----------------------------------------------------------
> =
> (Updated Nov. 10, 2011, 12:05 p.m.)
> =
> =
> Review request for KDevelop and Quanta.
> =
> =
> Description
> -------
> =
> Some changes on the Interface of ISourceFormatter from the kdevplatform p=
roject broke compiling of quanta.
> This Patch fixes the interface of the SourceFormatter derived classes and=
some calls to these methods with the new KUrl parameter inserted.
> =
> =
> Diffs
> -----
> =
> languages/xml/formatter/formatterplugin.h e8799f1 =
> languages/xml/formatter/formatterplugin.cpp 4b04725 =
> languages/xml/formatter/sgmlformatter.cpp 4a99d79 =
> languages/xml/language/completion/sgmlcodecompletionmodel.cpp 803760f =
> plugins/phpformatter/formatterplugin.h 8b462bc =
> plugins/phpformatter/formatterplugin.cpp 761d635 =
> =
> Diff: http://git.reviewboard.kde.org/r/103106/diff/diff
> =
> =
> Testing
> -------
> =
> Quanta compiles fine with that patch.
> =
> =
> Thanks,
> =
> Florian Zumkeller-Quast
> =
>
--===============4156075558380152953==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"http://git.reviewboard.kde.org/r/103106/">http://git.revie=
wboard.kde.org/r/103106/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">commit is =
fine besides a few style issues, put the &,* always adjacent to the typ=
ename for consistency please.
if you have commit rights, please fix this before pushing.
otherwise send me this patch as created by "git format-patch" - i=
f possible with the style issue fixed. otherwise I'll do that.
thanks </pre>
<br />
<div>
<table width=3D"100%" border=3D"0" bgcolor=3D"white" style=3D"border: 1px s=
olid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan=3D"4" bgcolor=3D"#F0F0F0" style=3D"border-bottom: 1px solid =
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href=3D"http://git.reviewboard.kde.org/r/103106/diff/1/?file=3D40786=
#file40786line162" style=3D"color: black; font-weight: bold; text-decoratio=
n: underline;">languages/xml/formatter/formatterplugin.cpp</a>
<span style=3D"font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style=3D"background-color: #e4d9cb; padding: 4px 8px; text-align: c=
enter;">
<tr>
<td colspan=3D"4"><pre style=3D"font-size: 8pt; line-height: 140%; margi=
n: 0; ">QString FormatterPlugin::highlightModeForMime ( const KMimeType::Pt=
r &mime ) {</pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">162</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "><span class=3D"n">QString</span> <span class=
=3D"n">FormatterPlugin</span><span class=3D"o">::</span><span class=3D"n">f=
ormatSource</span> <span class=3D"p"><span class=3D"hl">(</span></span><spa=
n class=3D"hl"> </span><span class=3D"k">const</span> <span class=3D"n">QSt=
ring</span><span class=3D"o"><span class=3D"hl">&</span></span><span cl=
ass=3D"hl"> </span><span class=3D"n">text</span><span class=3D"p">,</span> =
<span class=3D"k">const</span> <span class=3D"n">KMimeType</span><span clas=
s=3D"o">::</span><span class=3D"n">Ptr</span><span class=3D"o"><span class=
=3D"hl">&</span></span><span class=3D"hl"> </span><span class=3D"n">mim=
e</span><span class=3D"p">,</span> <span class=3D"k">const</span> <span cla=
ss=3D"n">QString</span><span class=3D"o">&</span> <span class=3D"n">lef=
tContext</span><span class=3D"p">,</span> <span class=3D"k">const</span> <s=
pan class=3D"n">QString</span><span class=3D"o">&</span> <span class=3D=
"n">rightContext</span> <span class=3D"p"><span class=3D"hl">)</span></span=
><span class=3D"hl"> </span><span class=3D"p"><span class=3D"hl">{</span></=
span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">162</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "><span class=3D"n">QString</span> <span class=
=3D"n">FormatterPlugin</span><span class=3D"o">::</span><span class=3D"n">f=
ormatSource</span><span class=3D"p"><span class=3D"hl">(</span></span><span=
class=3D"k">const</span> <span class=3D"n">QString</span> <span class=3D"o=
"><span class=3D"hl">&</span></span><span class=3D"n">text</span><span =
class=3D"p"><span class=3D"hl">,</span></span><span class=3D"hl"> </span><s=
pan class=3D"k"><span class=3D"hl">const</span></span><span class=3D"hl"> <=
/span><span class=3D"n"><span class=3D"hl">KUrl</span></span><span class=3D=
"o"><span class=3D"hl">&</span></span><span class=3D"hl"> </span><span =
class=3D"n"><span class=3D"hl">url</span></span><span class=3D"p">,</span> =
<span class=3D"k">const</span> <span class=3D"n">KMimeType</span><span clas=
s=3D"o">::</span><span class=3D"n">Ptr</span> <span class=3D"o"><span class=
=3D"hl">&</span></span><span class=3D"n">mime</span><span class=3D"p">,=
</span> <span class=3D"k">const</span> <span class=3D"n">QString</span><spa=
n class=3D"o">&</span> <span class=3D"n">leftContext</span><span class=
=3D"hl"> </span><span class=3D"o"><span class=3D"hl">=3D</span></span><span=
class=3D"hl"> </span><span class=3D"n"><span class=3D"hl">QString</span></=
span><span class=3D"p"><span class=3D"hl">()</span>,</span> <span class=3D"=
k">const</span> <span class=3D"n">QString</span><span class=3D"o">&</sp=
an> <span class=3D"n">rightContext</span> <span class=3D"o"><span class=3D"=
hl">=3D</span></span><span class=3D"hl"> </span><span class=3D"n"><span cla=
ss=3D"hl">QString</span></span><span class=3D"p"><span class=3D"hl">())</sp=
an></span></pre></td>
</tr>
</tbody>
</table>
<pre style=3D"margin-left: 2em; white-space: pre-wrap; white-space: -moz-pr=
e-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-=
word;">please put the & adjacent to the typename for consistency</pre>
</div>
<br />
<div>
<table width=3D"100%" border=3D"0" bgcolor=3D"white" style=3D"border: 1px s=
olid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan=3D"4" bgcolor=3D"#F0F0F0" style=3D"border-bottom: 1px solid =
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href=3D"http://git.reviewboard.kde.org/r/103106/diff/1/?file=3D40786=
#file40786line168" style=3D"color: black; font-weight: bold; text-decoratio=
n: underline;">languages/xml/formatter/formatterplugin.cpp</a>
<span style=3D"font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style=3D"background-color: #e4d9cb; padding: 4px 8px; text-align: c=
enter;">
<tr>
<td colspan=3D"2"><pre style=3D"font-size: 8pt; line-height: 140%; margi=
n: 0; ">QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle=
style, const QString& text, const KMimeType::Ptr& mime, const QStr=
ing& leftContext, const QString& rightContext)</pre></td>
<td colspan=3D"2"><pre style=3D"font-size: 8pt; line-height: 140%; margi=
n: 0; "></pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">167</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "><span class=3D"n">QString</span> <span class=
=3D"n">FormatterPlugin</span><span class=3D"o">::</span><span class=3D"n">f=
ormatSourceWithStyle</span><span class=3D"p">(</span><span class=3D"n">Sour=
ceFormatterStyle</span> <span class=3D"n">style</span><span class=3D"p">,</=
span> <span class=3D"k">const</span> <span class=3D"n">QString</span><span =
class=3D"o">&</span> <span class=3D"n">text</span><span class=3D"p">,</=
span> <span class=3D"k">const</span> <span class=3D"n">KMimeType</span><spa=
n class=3D"o">::</span><span class=3D"n">Ptr</span><span class=3D"o"><span =
class=3D"hl">&</span></span><span class=3D"hl"> </span><span class=3D"n=
">mime</span><span class=3D"p">,</span> <span class=3D"k">const</span> <spa=
n class=3D"n">QString</span><span class=3D"o">&</span> <span class=3D"n=
">leftContext</span><span class=3D"p">,</span> <span class=3D"k">const</spa=
n> <span class=3D"n">QString</span><span class=3D"o">&</span> <span cla=
ss=3D"n">rightContext</span><span class=3D"p"><span class=3D"hl">)</span></=
span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">168</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "><span class=3D"n">QString</span> <span class=
=3D"n">FormatterPlugin</span><span class=3D"o">::</span><span class=3D"n">f=
ormatSourceWithStyle</span><span class=3D"p">(</span><span class=3D"n">Sour=
ceFormatterStyle</span> <span class=3D"n">style</span><span class=3D"p">,</=
span> <span class=3D"k">const</span> <span class=3D"n">QString</span><span =
class=3D"o">&</span> <span class=3D"n">text</span><span class=3D"p"><sp=
an class=3D"hl">,</span></span><span class=3D"hl"> </span><span class=3D"k"=
><span class=3D"hl">const</span></span><span class=3D"hl"> </span><span cla=
ss=3D"n"><span class=3D"hl">KUrl</span></span><span class=3D"o"><span class=
=3D"hl">&</span></span><span class=3D"hl"> </span><span class=3D"n"><sp=
an class=3D"hl">url</span></span><span class=3D"p">,</span> <span class=3D"=
k">const</span> <span class=3D"n">KMimeType</span><span class=3D"o">::</spa=
n><span class=3D"n">Ptr</span><span class=3D"hl"> </span><span class=3D"o">=
<span class=3D"hl">&</span></span><span class=3D"n">mime</span><span cl=
ass=3D"p">,</span> <span class=3D"k">const</span> <span class=3D"n">QString=
</span><span class=3D"o">&</span> <span class=3D"n">leftContext</span><=
span class=3D"hl"> </span><span class=3D"o"><span class=3D"hl">=3D</span></=
span><span class=3D"hl"> </span><span class=3D"n"><span class=3D"hl">QStrin=
g</span></span><span class=3D"p"><span class=3D"hl">()</span>,</span> <span=
class=3D"k">const</span> <span class=3D"n">QString</span><span class=3D"o"=
>&</span> <span class=3D"n">rightContext</span><span class=3D"hl"> </sp=
an><span class=3D"o"><span class=3D"hl">=3D</span></span><span class=3D"hl"=
> </span><span class=3D"n"><span class=3D"hl">QString</span></span><span cl=
ass=3D"p"><span class=3D"hl">())</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style=3D"margin-left: 2em; white-space: pre-wrap; white-space: -moz-pr=
e-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-=
word;">also here, & adjacent to the typename please</pre>
</div>
<br />
<div>
<table width=3D"100%" border=3D"0" bgcolor=3D"white" style=3D"border: 1px s=
olid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan=3D"4" bgcolor=3D"#F0F0F0" style=3D"border-bottom: 1px solid =
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href=3D"http://git.reviewboard.kde.org/r/103106/diff/1/?file=3D40789=
#file40789line55" style=3D"color: black; font-weight: bold; text-decoration=
: underline;">plugins/phpformatter/formatterplugin.h</a>
<span style=3D"font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style=3D"background-color: #e4d9cb; padding: 4px 8px; text-align: c=
enter;">
<tr>
<td colspan=3D"4"><pre style=3D"font-size: 8pt; line-height: 140%; margi=
n: 0; ">public:</pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">55</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"k">virtual</span> <span cla=
ss=3D"n">QString</span> <span class=3D"n">formatSourceWithStyle</span><span=
class=3D"p">(</span><span class=3D"n">KDevelop</span><span class=3D"o">::<=
/span><span class=3D"n">SourceFormatterStyle</span> <span class=3D"p">,</sp=
an> <span class=3D"k">const</span> <span class=3D"n">QString</span><span cl=
ass=3D"o">&</span> <span class=3D"n">text</span><span class=3D"p">,</sp=
an> <span class=3D"k">const</span> <span class=3D"n">KMimeType</span><span =
class=3D"o">::</span><span class=3D"n">Ptr</span><span class=3D"o"><span cl=
ass=3D"hl">&</span></span><span class=3D"hl"> </span><span class=3D"n">=
mime</span><span class=3D"p">,</span> <span class=3D"k">const</span> <span =
class=3D"n">QString</span><span class=3D"o">&</span> <span class=3D"n">=
leftContext</span><span class=3D"hl"> </span><span class=3D"o"><span class=
=3D"hl">=3D</span></span><span class=3D"hl"> </span><span class=3D"n"><span=
class=3D"hl">QString</span></span><span class=3D"p"><span class=3D"hl">()<=
/span>,</span> <span class=3D"k">const</span> <span class=3D"n">QString</sp=
an><span class=3D"o">&</span> <span class=3D"n">rightContext</span><spa=
n class=3D"hl"> </span><span class=3D"o"><span class=3D"hl">=3D</span></spa=
n><span class=3D"hl"> </span><span class=3D"n"><span class=3D"hl">QString</=
span></span><span class=3D"p"><span class=3D"hl">()</span>);</span></pre></=
td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">55</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "> <span class=3D"k">virtual</span> <span cla=
ss=3D"n">QString</span> <span class=3D"n">formatSourceWithStyle</span><span=
class=3D"p">(</span><span class=3D"n">KDevelop</span><span class=3D"o">::<=
/span><span class=3D"n">SourceFormatterStyle</span><span class=3D"p">,</spa=
n> <span class=3D"k">const</span> <span class=3D"n">QString</span><span cla=
ss=3D"o">&</span> <span class=3D"n">text</span><span class=3D"p">,</spa=
n> <span class=3D"k">const</span> <span class=3D"n">K<span class=3D"hl">Url=
</span></span><span class=3D"o"><span class=3D"hl">&</span></span><span=
class=3D"hl"> </span><span class=3D"n"><span class=3D"hl">url</span></span=
><span class=3D"p"><span class=3D"hl">,</span></span><span class=3D"hl"> </=
span><span class=3D"k"><span class=3D"hl">const</span></span><span class=3D=
"hl"> </span><span class=3D"n"><span class=3D"hl">K</span>MimeType</span><s=
pan class=3D"o">::</span><span class=3D"n">Ptr</span> <span class=3D"o"><sp=
an class=3D"hl">&</span></span><span class=3D"n">mime</span><span class=
=3D"p">,</span> <span class=3D"k">const</span> <span class=3D"n">QString</s=
pan><span class=3D"o">&</span> <span class=3D"n">leftContext</span><spa=
n class=3D"p">,</span> <span class=3D"k">const</span> <span class=3D"n">QSt=
ring</span><span class=3D"o">&</span> <span class=3D"n">rightContext</s=
pan><span class=3D"p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style=3D"margin-left: 2em; white-space: pre-wrap; white-space: -moz-pr=
e-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-=
word;">again, please & adjacent to typename</pre>
</div>
<br />
<div>
<table width=3D"100%" border=3D"0" bgcolor=3D"white" style=3D"border: 1px s=
olid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan=3D"4" bgcolor=3D"#F0F0F0" style=3D"border-bottom: 1px solid =
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href=3D"http://git.reviewboard.kde.org/r/103106/diff/1/?file=3D40790=
#file40790line92" style=3D"color: black; font-weight: bold; text-decoration=
: underline;">plugins/phpformatter/formatterplugin.cpp</a>
<span style=3D"font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style=3D"background-color: #e4d9cb; padding: 4px 8px; text-align: c=
enter;">
<tr>
<td colspan=3D"4"><pre style=3D"font-size: 8pt; line-height: 140%; margi=
n: 0; ">QString FormatterPlugin::description() {</pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">92</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "><span class=3D"n">QString</span> <span class=
=3D"n">FormatterPlugin</span><span class=3D"o">::</span><span class=3D"n">f=
ormatSource</span> <span class=3D"p"><span class=3D"hl">(</span></span><spa=
n class=3D"hl"> </span><span class=3D"k">const</span> <span class=3D"n">QSt=
ring</span><span class=3D"o"><span class=3D"hl">&</span></span><span cl=
ass=3D"hl"> </span><span class=3D"n">text</span><span class=3D"p">,</span> =
<span class=3D"k">const</span> <span class=3D"n">KMimeType</span><span clas=
s=3D"o">::</span><span class=3D"n">Ptr</span><span class=3D"o"><span class=
=3D"hl">&</span></span><span class=3D"hl"> </span><span class=3D"n">mim=
e</span><span class=3D"p">,</span> <span class=3D"k">const</span> <span cla=
ss=3D"n">QString</span><span class=3D"o">&</span> <span class=3D"n">lef=
tContext</span><span class=3D"p">,</span> <span class=3D"k">const</span> <s=
pan class=3D"n">QString</span><span class=3D"o">&</span> <span class=3D=
"n">rightContext</span> <span class=3D"p"><span class=3D"hl">)</span></span=
><span class=3D"hl"> </span><span class=3D"p"><span class=3D"hl">{</span></=
span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">92</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "><span class=3D"n">QString</span> <span class=
=3D"n">FormatterPlugin</span><span class=3D"o">::</span><span class=3D"n">f=
ormatSource</span><span class=3D"p"><span class=3D"hl">(</span></span><span=
class=3D"k">const</span> <span class=3D"n">QString</span> <span class=3D"o=
"><span class=3D"hl">&</span></span><span class=3D"n">text</span><span =
class=3D"p"><span class=3D"hl">,</span></span><span class=3D"hl"> </span><s=
pan class=3D"k"><span class=3D"hl">const</span></span><span class=3D"hl"> <=
/span><span class=3D"n"><span class=3D"hl">KUrl</span></span><span class=3D=
"o"><span class=3D"hl">&</span></span><span class=3D"hl"> </span><span =
class=3D"n"><span class=3D"hl">url</span></span><span class=3D"p">,</span> =
<span class=3D"k">const</span> <span class=3D"n">KMimeType</span><span clas=
s=3D"o">::</span><span class=3D"n">Ptr</span> <span class=3D"o"><span class=
=3D"hl">&</span></span><span class=3D"n">mime</span><span class=3D"p">,=
</span> <span class=3D"k">const</span> <span class=3D"n">QString</span><spa=
n class=3D"o">&</span> <span class=3D"n">leftContext</span><span class=
=3D"hl"> </span><span class=3D"o"><span class=3D"hl">=3D</span></span><span=
class=3D"hl"> </span><span class=3D"n"><span class=3D"hl">QString</span></=
span><span class=3D"p"><span class=3D"hl">()</span>,</span> <span class=3D"=
k">const</span> <span class=3D"n">QString</span><span class=3D"o">&</sp=
an> <span class=3D"n">rightContext</span> <span class=3D"o"><span class=3D"=
hl">=3D</span></span><span class=3D"hl"> </span><span class=3D"n"><span cla=
ss=3D"hl">QString</span></span><span class=3D"p"><span class=3D"hl">())</sp=
an></span></pre></td>
</tr>
</tbody>
</table>
<pre style=3D"margin-left: 2em; white-space: pre-wrap; white-space: -moz-pr=
e-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-=
word;">& again... :)</pre>
</div>
<br />
<div>
<table width=3D"100%" border=3D"0" bgcolor=3D"white" style=3D"border: 1px s=
olid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan=3D"4" bgcolor=3D"#F0F0F0" style=3D"border-bottom: 1px solid =
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href=3D"http://git.reviewboard.kde.org/r/103106/diff/1/?file=3D40790=
#file40790line103" style=3D"color: black; font-weight: bold; text-decoratio=
n: underline;">plugins/phpformatter/formatterplugin.cpp</a>
<span style=3D"font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style=3D"background-color: #e4d9cb; padding: 4px 8px; text-align: c=
enter;">
<tr>
<td colspan=3D"2"><pre style=3D"font-size: 8pt; line-height: 140%; margi=
n: 0; ">QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle=
style, const QString& text, const KMimeType::Ptr& mime, const QStr=
ing& leftContext, const QString& rightContext)</pre></td>
<td colspan=3D"2"><pre style=3D"font-size: 8pt; line-height: 140%; margi=
n: 0; "></pre></td>
</tr>
</tbody>
=
=
<tbody>
<tr>
<th bgcolor=3D"#e9eaa8" style=3D"border-right: 1px solid #C0C0C0;" alig=
n=3D"right"><font size=3D"2">102</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "><span class=3D"n">QString</span> <span class=
=3D"n">FormatterPlugin</span><span class=3D"o">::</span><span class=3D"n">f=
ormatSourceWithStyle</span><span class=3D"p">(</span><span class=3D"n">Sour=
ceFormatterStyle</span> <span class=3D"n">style</span><span class=3D"p">,</=
span> <span class=3D"k">const</span> <span class=3D"n">QString</span><span =
class=3D"o">&</span> <span class=3D"n">text</span><span class=3D"p">,</=
span> <span class=3D"k">const</span> <span class=3D"n">KMimeType</span><spa=
n class=3D"o">::</span><span class=3D"n">Ptr</span><span class=3D"o"><span =
class=3D"hl">&</span></span><span class=3D"hl"> </span><span class=3D"n=
">mime</span><span class=3D"p">,</span> <span class=3D"k">const</span> <spa=
n class=3D"n">QString</span><span class=3D"o">&</span> <span class=3D"n=
">leftContext</span><span class=3D"p">,</span> <span class=3D"k">const</spa=
n> <span class=3D"n">QString</span><span class=3D"o">&</span> <span cla=
ss=3D"n">rightContext</span><span class=3D"p"><span class=3D"hl">)</span></=
span></pre></td>
<th bgcolor=3D"#e9eaa8" style=3D"border-left: 1px solid #C0C0C0; border=
-right: 1px solid #C0C0C0;" align=3D"right"><font size=3D"2">103</font></th>
<td bgcolor=3D"#fdfebc" width=3D"50%"><pre style=3D"font-size: 8pt; lin=
e-height: 140%; margin: 0; "><span class=3D"n">QString</span> <span class=
=3D"n">FormatterPlugin</span><span class=3D"o">::</span><span class=3D"n">f=
ormatSourceWithStyle</span><span class=3D"p">(</span><span class=3D"n">Sour=
ceFormatterStyle</span> <span class=3D"n">style</span><span class=3D"p">,</=
span> <span class=3D"k">const</span> <span class=3D"n">QString</span><span =
class=3D"o">&</span> <span class=3D"n">text</span><span class=3D"p"><sp=
an class=3D"hl">,</span></span><span class=3D"hl"> </span><span class=3D"k"=
><span class=3D"hl">const</span></span><span class=3D"hl"> </span><span cla=
ss=3D"n"><span class=3D"hl">KUrl</span></span><span class=3D"o"><span class=
=3D"hl">&</span></span><span class=3D"hl"> </span><span class=3D"n"><sp=
an class=3D"hl">url</span></span><span class=3D"p">,</span> <span class=3D"=
k">const</span> <span class=3D"n">KMimeType</span><span class=3D"o">::</spa=
n><span class=3D"n">Ptr</span><span class=3D"hl"> </span><span class=3D"o">=
<span class=3D"hl">&</span></span><span class=3D"n">mime</span><span cl=
ass=3D"p">,</span> <span class=3D"k">const</span> <span class=3D"n">QString=
</span><span class=3D"o">&</span> <span class=3D"n">leftContext</span><=
span class=3D"hl"> </span><span class=3D"o"><span class=3D"hl">=3D</span></=
span><span class=3D"hl"> </span><span class=3D"n"><span class=3D"hl">QStrin=
g</span></span><span class=3D"p"><span class=3D"hl">()</span>,</span> <span=
class=3D"k">const</span> <span class=3D"n">QString</span><span class=3D"o"=
>&</span> <span class=3D"n">rightContext</span><span class=3D"hl"> </sp=
an><span class=3D"o"><span class=3D"hl">=3D</span></span><span class=3D"hl"=
> </span><span class=3D"n"><span class=3D"hl">QString</span></span><span cl=
ass=3D"p"><span class=3D"hl">())</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style=3D"margin-left: 2em; white-space: pre-wrap; white-space: -moz-pr=
e-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-=
word;">& again... :)</pre>
</div>
<br />
<p>- Milian</p>
<br />
<p>On November 10th, 2011, 12:05 p.m., Florian Zumkeller-Quast wrote:</p>
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>
<p style=3D"color: grey;"><i>Updated Nov. 10, 2011, 12:05 p.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Some changes on the Interface of ISourceFormatter from the k=
devplatform project broke compiling of quanta.
This Patch fixes the interface of the SourceFormatter derived classes and s=
ome calls to these methods with the new KUrl parameter inserted.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Quanta compiles fine with that patch.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>languages/xml/formatter/formatterplugin.h <span style=3D"color: grey">=
(e8799f1)</span></li>
<li>languages/xml/formatter/formatterplugin.cpp <span style=3D"color: grey=
">(4b04725)</span></li>
<li>languages/xml/formatter/sgmlformatter.cpp <span style=3D"color: grey">=
(4a99d79)</span></li>
<li>languages/xml/language/completion/sgmlcodecompletionmodel.cpp <span st=
yle=3D"color: grey">(803760f)</span></li>
<li>plugins/phpformatter/formatterplugin.h <span style=3D"color: grey">(8b=
462bc)</span></li>
<li>plugins/phpformatter/formatterplugin.cpp <span style=3D"color: grey">(=
761d635)</span></li>
</ul>
<p><a href=3D"http://git.reviewboard.kde.org/r/103106/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4156075558380152953==--
--===============3446535247089146494==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
quanta-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/quanta-devel
--===============3446535247089146494==--