Re: Review Request: Fix compile break of quanta
"Florian Zumkeller-Quast" <[email protected]> Thu, 10 Nov 2011 15:42:26 -0000
| Newsgroups | gmane.comp.kde.devel.quanta |
|---|---|
| Message-ID | <[email protected]> |
--===============2224146254489854045==
Content-Type: multipart/alternative;
boundary="===============4947654134682370686=="
--===============4947654134682370686==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103106/
-----------------------------------------------------------
(Updated Nov. 10, 2011, 3:42 p.m.)
Review request for KDevelop and Quanta.
Changes
-------
The patch created by git format-patch. I fixed the style issues.
Description
-------
Some changes on the Interface of ISourceFormatter from the kdevplatform pro=
ject broke compiling of quanta.
This Patch fixes the interface of the SourceFormatter derived classes and s=
ome calls to these methods with the new KUrl parameter inserted.
Diffs
-----
languages/xml/formatter/formatterplugin.h e8799f1 =
languages/xml/formatter/formatterplugin.cpp 4b04725 =
languages/xml/formatter/sgmlformatter.cpp 4a99d79 =
languages/xml/language/completion/sgmlcodecompletionmodel.cpp 803760f =
plugins/phpformatter/formatterplugin.h 8b462bc =
plugins/phpformatter/formatterplugin.cpp 761d635 =
Diff: http://git.reviewboard.kde.org/r/103106/diff/diff
Testing
-------
Quanta compiles fine with that patch.
Thanks,
Florian Zumkeller-Quast
--===============4947654134682370686==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"http://git.reviewboard.kde.org/r/103106/">http://git.revie=
wboard.kde.org/r/103106/</a>
</td>
</tr>
</table>
<br />
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>
<p style=3D"color: grey;"><i>Updated Nov. 10, 2011, 3:42 p.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</=
h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">The patch created by git format-patch. I fixed the style iss=
ues.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Some changes on the Interface of ISourceFormatter from the k=
devplatform project broke compiling of quanta.
This Patch fixes the interface of the SourceFormatter derived classes and s=
ome calls to these methods with the new KUrl parameter inserted.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Quanta compiles fine with that patch.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>languages/xml/formatter/formatterplugin.h <span style=3D"color: grey">=
(e8799f1)</span></li>
<li>languages/xml/formatter/formatterplugin.cpp <span style=3D"color: grey=
">(4b04725)</span></li>
<li>languages/xml/formatter/sgmlformatter.cpp <span style=3D"color: grey">=
(4a99d79)</span></li>
<li>languages/xml/language/completion/sgmlcodecompletionmodel.cpp <span st=
yle=3D"color: grey">(803760f)</span></li>
<li>plugins/phpformatter/formatterplugin.h <span style=3D"color: grey">(8b=
462bc)</span></li>
<li>plugins/phpformatter/formatterplugin.cpp <span style=3D"color: grey">(=
761d635)</span></li>
</ul>
<p><a href=3D"http://git.reviewboard.kde.org/r/103106/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4947654134682370686==--
--===============2224146254489854045==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
quanta-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/quanta-devel
--===============2224146254489854045==--