Re: Review Request: Add more php example code to show the formatters impact

"Milian Wolff" <[email protected]> Fri, 23 Dec 2011 20:17:48 -0000
Newsgroups gmane.comp.kde.devel.quanta
Message-ID <[email protected]>
--===============4175661748925931896==
Content-Type: multipart/alternative;
	boundary="===============2111379038009278504=="

--===============2111379038009278504==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103388/#review9220
-----------------------------------------------------------


Uhm sorry, but when I download the diff it is still not in the "format-patc=
h" format. Just look at the downloaded file, it directly starts with the pa=
tch and gives no information about you, nor any commit message or such.

please try again

- Milian Wolff


On Dec. 15, 2011, 1:08 a.m., Florian Zumkeller-Quast wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103388/
> -----------------------------------------------------------
> =

> (Updated Dec. 15, 2011, 1:08 a.m.)
> =

> =

> Review request for KDevelop and Quanta.
> =

> =

> Description
> -------
> =

> Added some more php example code to show the impact of the formatter if a=
pplied
> =

> =

> Diffs
> -----
> =

>   plugins/phpformatter/formatterplugin.cpp f1ca6fd =

> =

> Diff: http://git.reviewboard.kde.org/r/103388/diff/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Florian Zumkeller-Quast
> =

>


--===============2111379038009278504==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable




<html>
 <body>
  <div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"http://git.reviewboard.kde.org/r/103388/">http://git.revie=
wboard.kde.org/r/103388/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Uhm sorry,=
 but when I download the diff it is still not in the &quot;format-patch&quo=
t; format. Just look at the downloaded file, it directly starts with the pa=
tch and gives no information about you, nor any commit message or such.

please try again</pre>
 <br />







<p>- Milian</p>


<br />
<p>On December 15th, 2011, 1:08 a.m., Florian Zumkeller-Quast wrote:</p>






<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>


<p style=3D"color: grey;"><i>Updated Dec. 15, 2011, 1:08 a.m.</i></p>






<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
 <table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Added some more php example code to show the impact of the f=
ormatter if applied</pre>
  </td>
 </tr>
</table>





<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 </h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>plugins/phpformatter/formatterplugin.cpp <span style=3D"color: grey">(=
f1ca6fd)</span></li>

</ul>

<p><a href=3D"http://git.reviewboard.kde.org/r/103388/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============2111379038009278504==--

--===============4175661748925931896==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
quanta-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/quanta-devel

--===============4175661748925931896==--