Re: Review Request: Fix compiling of quanta master
"Commit Hook" <[email protected]> Fri, 23 Dec 2011 23:26:07 -0000
| Newsgroups | gmane.comp.kde.devel.kdevelop,gmane.comp.kde.devel.quanta |
|---|---|
| Message-ID | <[email protected]> |
--===============0120840869==
Content-Type: multipart/alternative;
boundary="===============3634941950774283564=="
--===============3634941950774283564==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103386/#review9225
-----------------------------------------------------------
This review has been submitted with commit 98ee7f47fc416555d4bb854428776c17=
fec2d802 by Florian Zumkeller-Quast to branch master.
- Commit Hook
On Dec. 23, 2011, 10:07 p.m., Florian Zumkeller-Quast wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103386/
> -----------------------------------------------------------
> =
> (Updated Dec. 23, 2011, 10:07 p.m.)
> =
> =
> Review request for KDevelop and Quanta.
> =
> =
> Description
> -------
> =
> Since the last changes of ISourceFormatter from KDevPlatform Quanta was b=
roken and did not compile.
> This patch fixes the compiling issues by changing phpformatterplugin and =
xmlformatterplugin to the new interface of ISourceFormatter.
> =
> During the testing it looked to me that there are two different options s=
toring the indentation value for a formatter:
> "INDENT" and "indent_size". Because only the latter contained a non-zero =
value, i changed the behaviour to use the latter one.
> =
> =
> Diffs
> -----
> =
> languages/xml/formatter/formatterplugin.h dbe183a =
> languages/xml/formatter/formatterplugin.cpp 4e62a1e =
> plugins/phpformatter/formatterplugin.h 6dc7028 =
> plugins/phpformatter/formatterplugin.cpp f1ca6fd =
> =
> Diff: http://git.reviewboard.kde.org/r/103386/diff/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Florian Zumkeller-Quast
> =
>
--===============3634941950774283564==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"http://git.reviewboard.kde.org/r/103386/">http://git.revie=
wboard.kde.org/r/103386/</a>
</td>
</tr>
</table>
<br />
<pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This revie=
w has been submitted with commit 98ee7f47fc416555d4bb854428776c17fec2d802 b=
y Florian Zumkeller-Quast to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 23rd, 2011, 10:07 p.m., Florian Zumkeller-Quast wrote:</p>
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>
<p style=3D"color: grey;"><i>Updated Dec. 23, 2011, 10:07 p.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Since the last changes of ISourceFormatter from KDevPlatform=
Quanta was broken and did not compile.
This patch fixes the compiling issues by changing phpformatterplugin and xm=
lformatterplugin to the new interface of ISourceFormatter.
During the testing it looked to me that there are two different options sto=
ring the indentation value for a formatter:
"INDENT" and "indent_size". Because only the latter con=
tained a non-zero value, i changed the behaviour to use the latter one.</pr=
e>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>languages/xml/formatter/formatterplugin.h <span style=3D"color: grey">=
(dbe183a)</span></li>
<li>languages/xml/formatter/formatterplugin.cpp <span style=3D"color: grey=
">(4e62a1e)</span></li>
<li>plugins/phpformatter/formatterplugin.h <span style=3D"color: grey">(6d=
c7028)</span></li>
<li>plugins/phpformatter/formatterplugin.cpp <span style=3D"color: grey">(=
f1ca6fd)</span></li>
</ul>
<p><a href=3D"http://git.reviewboard.kde.org/r/103386/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3634941950774283564==--
--===============0120840869==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
--
KDevelop-devel mailing list
[email protected]
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
--===============0120840869==--