Review Request: Actually use ExecuteBrowserPlugin in XDebugJob
"Dominik Schmidt" <[email protected]> Fri, 13 Apr 2012 23:29:07 -0000
| Newsgroups | gmane.comp.kde.devel.kdevelop,gmane.comp.kde.devel.quanta |
|---|---|
| Message-ID | <[email protected]> |
--===============0912143909==
Content-Type: multipart/alternative;
boundary="===============8487011941787599212=="
--===============8487011941787599212==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104595/
-----------------------------------------------------------
Review request for KDevelop and Quanta.
Description
-------
Currently the XDebugJob always uses QDesktopServices::openUrl() to open the=
debug page in the browser, this patch makes use of the ExecuteBrowserPlugi=
n instance that is already present in XDebug job so the configured browser =
is launched.
Also it makes BrowserAppJob launch the external browser KProc with .startDe=
tached() instead of .execute() to prevent freezing of the KDevelop GUI.
Arguments are currently ignored still, a patch for that is following
Feel free to nitpick, I haven't done any KDE coding in a while and would li=
ke to hear any suggestion for improvements :-)
Diffs
-----
debuggers/xdebug/debugjob.h 9925733 =
debuggers/xdebug/debugjob.cpp 0f04914 =
plugins/executebrowser/browserappjob.h 37ff700 =
plugins/executebrowser/browserappjob.cpp a211205 =
plugins/executebrowser/executebrowserplugin.h 7c78733 =
plugins/executebrowser/executebrowserplugin.cpp 921142f =
plugins/executebrowser/iexecutebrowserplugin.h f786622 =
Diff: http://git.reviewboard.kde.org/r/104595/diff/
Testing
-------
It works ... ;-)
Thanks,
Dominik Schmidt
--===============8487011941787599212==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"http://git.reviewboard.kde.org/r/104595/">http://git.revie=
wboard.kde.org/r/104595/</a>
</td>
</tr>
</table>
<br />
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Quanta.</div>
<div>By Dominik Schmidt.</div>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Currently the XDebugJob always uses QDesktopServices::openUr=
l() to open the debug page in the browser, this patch makes use of the Exec=
uteBrowserPlugin instance that is already present in XDebug job so the conf=
igured browser is launched.
Also it makes BrowserAppJob launch the external browser KProc with .startDe=
tached() instead of .execute() to prevent freezing of the KDevelop GUI.
Arguments are currently ignored still, a patch for that is following
Feel free to nitpick, I haven't done any KDE coding in a while and woul=
d like to hear any suggestion for improvements :-)</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">It works ... ;-)</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>debuggers/xdebug/debugjob.h <span style=3D"color: grey">(9925733)</spa=
n></li>
<li>debuggers/xdebug/debugjob.cpp <span style=3D"color: grey">(0f04914)</s=
pan></li>
<li>plugins/executebrowser/browserappjob.h <span style=3D"color: grey">(37=
ff700)</span></li>
<li>plugins/executebrowser/browserappjob.cpp <span style=3D"color: grey">(=
a211205)</span></li>
<li>plugins/executebrowser/executebrowserplugin.h <span style=3D"color: gr=
ey">(7c78733)</span></li>
<li>plugins/executebrowser/executebrowserplugin.cpp <span style=3D"color: =
grey">(921142f)</span></li>
<li>plugins/executebrowser/iexecutebrowserplugin.h <span style=3D"color: g=
rey">(f786622)</span></li>
</ul>
<p><a href=3D"http://git.reviewboard.kde.org/r/104595/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8487011941787599212==--
--===============0912143909==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
--
KDevelop-devel mailing list
[email protected]
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
--===============0912143909==--