Re: Review Request 106939: Adapt the KDevPlatform Interface change (removed KDevelop::IOutputView::TakeOwnership) to fix build
"Albert Astals Cid" <[email protected]> Fri, 08 Feb 2013 21:38:35 -0000
| Newsgroups | gmane.comp.kde.devel.quanta |
|---|---|
| Message-ID | <[email protected]> |
--===============2799734140808920157==
Content-Type: multipart/alternative;
boundary="===============6849784804459979854=="
--===============6849784804459979854==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106939/#review27004
-----------------------------------------------------------
I see this has a ship it but the review is still open. Was it commited and forgot to close the review or is still uncommited?
- Albert Astals Cid
On Oct. 18, 2012, 10:10 a.m., Florian Zumkeller-Quast wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106939/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2012, 10:10 a.m.)
>
>
> Review request for Quanta.
>
>
> Description
> -------
>
> KDevPlatform Interface got changed, this adapts the change so the compile won't be broken anymore
>
>
> Diffs
> -----
>
> debuggers/crossfire/debugjob.cpp 26e7a8b
>
> Diff: http://git.reviewboard.kde.org/r/106939/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Florian Zumkeller-Quast
>
>
--===============6849784804459979854==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106939/">http://git.reviewboard.kde.org/r/106939/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see this has a ship it but the review is still open. Was it commited and forgot to close the review or is still uncommited?</pre>
<br />
<p>- Albert</p>
<br />
<p>On October 18th, 2012, 10:10 a.m. UTC, Florian Zumkeller-Quast wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Quanta.</div>
<div>By Florian Zumkeller-Quast.</div>
<p style="color: grey;"><i>Updated Oct. 18, 2012, 10:10 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KDevPlatform Interface got changed, this adapts the change so the compile won't be broken anymore</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/crossfire/debugjob.cpp <span style="color: grey">(26e7a8b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106939/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6849784804459979854==--
--===============2799734140808920157==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
quanta-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/quanta-devel
--===============2799734140808920157==--