New Defects reported by Coverity Scan for digiKam
scan-admin-S5/EvlXga/RWk0Htik3J/[email protected]
| Newsgroups | gmane.comp.kde.digikam.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi,
Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.
9 new defect(s) introduced to digiKam found with Coverity Scan.
21 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 9 of 9 defect(s)
** CID 1506653: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/imageeditor/editor/editorwindow.cpp: 2438 in Digikam::EditorWindow::slotSoftProofingOptions()()
________________________________________________________________________________________________________
*** CID 1506653: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/imageeditor/editor/editorwindow.cpp: 2438 in Digikam::EditorWindow::slotSoftProofingOptions()()
2432
2433 void EditorWindow::slotSoftProofingOptions()
2434 {
2435 // Adjusts global settings
2436
2437 QPointer<SoftProofDialog> dlg = new SoftProofDialog(this);
>>> CID 1506653: Error handling issues (CHECKED_RETURN)
>>> Calling "exec" without checking return value (as is done elsewhere 37 out of 46 times).
2438 dlg->exec();
2439
2440 d->viewSoftProofAction->setChecked(dlg->shallEnableSoftProofView());
2441 slotUpdateSoftProofingState();
2442 delete dlg;
2443 }
** CID 1506652: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/setup/setup.cpp: 665 in Digikam::Setup::onlineVersionCheck()()
________________________________________________________________________________________________________
*** CID 1506652: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/setup/setup.cpp: 665 in Digikam::Setup::onlineVersionCheck()()
659 [=]()
660 {
661 Setup::execSinglePage(nullptr, Setup::MiscellaneousPage);
662 }
663 );
664
>>> CID 1506652: Error handling issues (CHECKED_RETURN)
>>> Calling "exec" without checking return value (as is done elsewhere 37 out of 46 times).
665 dlg->exec();
666 }
667
** CID 1506651: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/libs/fileactionmanager/fileactionmngr.cpp: 95 in Digikam::FileActionMngr::requestShutDown()()
________________________________________________________________________________________________________
*** CID 1506651: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/libs/fileactionmanager/fileactionmngr.cpp: 95 in Digikam::FileActionMngr::requestShutDown()()
89 dialog->setMinimumDuration(100);
90 dialog->setLabelText(i18nc("@label", "Finishing tasks"));
91
92 connect(d, SIGNAL(signalTasksFinished()),
93 dialog, SLOT(accept()));
94
>>> CID 1506651: Error handling issues (CHECKED_RETURN)
>>> Calling "exec" without checking return value (as is done elsewhere 37 out of 46 times).
95 dialog->exec();
96
97 // Either, we finished and all is fine, or the user cancelled and we kill
98 shutDown();
99
100 return true;
** CID 1506650: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/app/views/tableview/tableview.cpp: 685 in Digikam::TableView::rename()()
________________________________________________________________________________________________________
*** CID 1506650: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/app/views/tableview/tableview.cpp: 685 in Digikam::TableView::rename()()
679 setFocus();
680 qApp->processEvents();
681
682 if (!newNamesList.isEmpty())
683 {
684 QPointer<AdvancedRenameProcessDialog> dlg2 = new AdvancedRenameProcessDialog(newNamesList, this);
>>> CID 1506650: Error handling issues (CHECKED_RETURN)
>>> Calling "exec" without checking return value (as is done elsewhere 37 out of 46 times).
685 dlg2->exec();
686
687 s->tableViewModel->scheduleResort();
688 urls = dlg2->failedUrls();
689 delete dlg2;
690 }
** CID 1506649: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/setup/setupicc.cpp: 874 in Digikam::SetupICC::profileInfo(const Digikam::IccProfile &)()
________________________________________________________________________________________________________
*** CID 1506649: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/setup/setupicc.cpp: 874 in Digikam::SetupICC::profileInfo(const Digikam::IccProfile &)()
868 {
869 QMessageBox::critical(this, i18n("Profile Error"), i18n("No profile is selected."));
870 return;
871 }
872
873 ICCProfileInfoDlg infoDlg(this, profile.filePath(), profile);
>>> CID 1506649: Error handling issues (CHECKED_RETURN)
>>> Calling "exec" without checking return value (as is done elsewhere 37 out of 46 times).
874 infoDlg.exec();
875 }
876
877 void SetupICC::slotMissingToggled(bool on)
878 {
879 if (!on)
** CID 1506648: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/imageeditor/editor/editorwindow.cpp: 1104 in Digikam::EditorWindow::execSavingProgressDialog()()
________________________________________________________________________________________________________
*** CID 1506648: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/imageeditor/editor/editorwindow.cpp: 1104 in Digikam::EditorWindow::execSavingProgressDialog()()
1098 m_savingProgressDialog->setMinimumDuration(1000);
1099 m_savingProgressDialog->setMaximum(100);
1100
1101 // we must enter a fully modal dialog, no QEventLoop is sufficient for KWin to accept longer waiting times
1102
1103 m_savingProgressDialog->setModal(true);
>>> CID 1506648: Error handling issues (CHECKED_RETURN)
>>> Calling "exec" without checking return value (as is done elsewhere 37 out of 46 times).
1104 m_savingProgressDialog->exec();
1105 }
1106
1107 bool EditorWindow::promptForOverWrite()
1108 {
1109
** CID 1506647: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/app/main/digikamapp_import.cpp: 128 in Digikam::DigikamApp::slotImportAddFolders()()
________________________________________________________________________________________________________
*** CID 1506647: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/app/main/digikamapp_import.cpp: 128 in Digikam::DigikamApp::slotImportAddFolders()()
122
123 if (t)
124 {
125 t->setSelectionMode(QAbstractItemView::MultiSelection);
126 }
127
>>> CID 1506647: Error handling issues (CHECKED_RETURN)
>>> Calling "exec" without checking return value (as is done elsewhere 37 out of 46 times).
128 dlg->exec();
129
130 if (!dlg->hasAcceptedUrls())
131 {
132 delete dlg;
133 return;
** CID 1506646: (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/imageeditor/editor/editorwindow.cpp: 1864 in Digikam::EditorWindow::showFileSaveDialog(const QUrl &, QUrl &)()
/home/gilles/Devel/8.x/core/utilities/imageeditor/editor/editorwindow.cpp: 1870 in Digikam::EditorWindow::showFileSaveDialog(const QUrl &, QUrl &)()
________________________________________________________________________________________________________
*** CID 1506646: (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/imageeditor/editor/editorwindow.cpp: 1864 in Digikam::EditorWindow::showFileSaveDialog(const QUrl &, QUrl &)()
1858
1859 if (d->currentWindowModalDialog)
1860 {
1861 // go application-modal - we will create utter confusion if descending into more than one window-modal dialog
1862
1863 imageFileSaveDialog->setModal(true);
>>> CID 1506646: (CHECKED_RETURN)
>>> Calling "exec" without checking return value (as is done elsewhere 37 out of 46 times).
1864 imageFileSaveDialog->exec();
1865 }
1866 else
1867 {
1868 imageFileSaveDialog->setWindowModality(Qt::WindowModal);
1869 d->currentWindowModalDialog = imageFileSaveDialog;
/home/gilles/Devel/8.x/core/utilities/imageeditor/editor/editorwindow.cpp: 1870 in Digikam::EditorWindow::showFileSaveDialog(const QUrl &, QUrl &)()
1864 imageFileSaveDialog->exec();
1865 }
1866 else
1867 {
1868 imageFileSaveDialog->setWindowModality(Qt::WindowModal);
1869 d->currentWindowModalDialog = imageFileSaveDialog;
>>> CID 1506646: (CHECKED_RETURN)
>>> Calling "exec" without checking return value (as is done elsewhere 37 out of 46 times).
1870 imageFileSaveDialog->exec();
1871 d->currentWindowModalDialog = nullptr;
1872 }
1873
1874 qApp->processEvents();
1875
** CID 1406231: Error handling issues (UNCAUGHT_EXCEPT)
/home/gilles/Devel/8.x/core/app/main/main.cpp: 98 in main()
________________________________________________________________________________________________________
*** CID 1406231: Error handling issues (UNCAUGHT_EXCEPT)
/home/gilles/Devel/8.x/core/app/main/main.cpp: 98 in main()
92 # include <shellapi.h>
93 # include <objbase.h>
94 #endif
95
96 using namespace Digikam;
97
>>> CID 1406231: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
98 int main(int argc, char* argv[])
99 {
100 SystemSettings system(QLatin1String("digikam"));
101
102 #if (QT_VERSION < QT_VERSION_CHECK(6, 0, 0))
103
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp2OAl-2Fauo86CB28HCT0-2BnD-2F6eFMYt863B1-2B0FLvU5y-2FRWSl8rMA4vGwCkGPp0f1hg-3DvTCe_IpEMwFcbl-2BY9RHaL2m6a3nuAxB4hfm4MTniX0gHjADU7irareF2Vaij5dvCmqoUz1KmSJSmXoUb1LhTmGXWShn4EyevR9waoFZwj3L7bOYdex20nVZ3cae2dYn2gvDKdf5tFmb84Yig94dwiXp2ggeGq1Qv3KAQDtdujGrPecCCoTOn0EKHm2AoLhwtcbe9pnL-2FZnnwht0HCaLquFgYkcA-3D-3D