Re: Some progress on ffmpeg 5

Gilles Caulier <[email protected]> Mon, 19 Sep 2022 07:10:22 +0200
Newsgroups gmane.comp.kde.digikam.devel
Message-ID <CAHFG6sGiVojRVMwSmfvo8Y22g48WwQ2NXqhRLuqp=C76rhEDUA@mail.gmail.com>
Hi Steven,

Excellent job. Great to see your progress with FFMPEG 5 support. This
will allow the release more quickly the next 8.0.0, probably in beta
stage, in a few weeks time, as finalizing QtAV integration was a
blocking task.

We will need to discuss the famous externalization of unit-test data
files in the dedicated git-fs repository, and especially the way to
access these files locally while running CI.

Best
Gilles


Le lun. 19 sept. 2022 à 06:50, Steven Robbins <[email protected]> a écrit :
>
> Hi,
>
> I have made some progress.  One of the issues was that the new code mixed up
> the order of avcodec_send_packet() and avcodec_receive_frame().  I've fixed
> that and created a couple tests that now pass on my machine.  Both FFMPEG 4
> and FFMPEG 5.
>
> There is still some odd behaviour, but at least one or two videos that I've
> tested do play.
>
> I still need to work on the tests, since I've cheated for now by putting the
> video file directly in digikam tree.  My plan is to fix that before proposing a
> merge.  If you're curious, though you can see the progress here: https://
> invent.kde.org/srobbins/digikam/-/tree/feature-qtav-testing
>
> Cheers,
> -Steve