Re: Hooked up the test data! -- DONE!!!

I Steve,

I ported all current unit tests to the LFS git repository, and now I
start to port cli tools from the tests area as new unit-tests.

Look my last commit :
https://invent.kde.org/graphics/digikam/commit/ec17376ffe9390dae22bf161e1b0601afbf44e21

DPlugins are not found in standard install paths on the CI
infrastructure. DImg image loaders cannot be used.

Best

Gilles

Le ven. 14 oct. 2022 à 19:10, Gilles Caulier
<[email protected]> a écrit :
>
> Exactly.
>
> All the rules are already implemented in these classes :
>
> Generic temp dir management:
>
> https://invent.kde.org/graphics/digikam/-/blob/master/core/tests/metadataengine/abstractunittest.h#L83
> https://invent.kde.org/graphics/digikam/-/blob/master/core/tests/metadataengine/abstractunittest.h#L90
>
> Exemple of file move to temp dir before to run unit test :
>
> https://invent.kde.org/graphics/digikam/-/blob/master/core/tests/metadataengine/erasemetadatatag_utest.cpp#L45
>
> Gilles
>
> Le ven. 14 oct. 2022 à 16:54, Steve Robbins <[email protected]> a écrit :
> >
> > Yeah, temp copies are a common thing. Would be nice to centralize that code .
> >
> > On October 14, 2022 8:27:18 a.m. CDT, Gilles Caulier <[email protected]> wrote:
> >>
> >> I migrated more data files from the album model and database. I plan
> >> to do more during this weekend.
> >>
> >> There is the advanced-rename part which is more complicated, as unit
> >> tests operate directly on data files. We need to perform a copy in a
> >> temporary directory first, as I do with the metadata engine.
> >>
> >> Gilles
> >>
> >> Le ven. 14 oct. 2022 à 15:22, Steven Robbins <[email protected]> a écrit :
> >>>
> >>>
> >>>  On Thursday, October 13, 2022 11:57:24 P.M. CDT Gilles Caulier wrote:
> >>>>
> >>>>  Hi Steve,
> >>>>
> >>>>  I reviewed your codes, changed some details, and ported the
> >>>>  metadataengine unit tests to the new repository.
> >>>
> >>>
> >>>  Thanks.  I see from your changes that I had missed out on coding/naming
> >>>  conventions in my test code.  I'll try to follow that better in future
> >>>  testing.
> >>>
> >>>  -Steve
> >
> > --
> > Sent from my Android device with K-9 Mail. Please excuse my brevity.