Re: Debugging digikam

Hi Mario,

Thanks for the feedback! Currently I don't like my approach of the layout.
I can checkout your approach to make it a little bit cleaner.
After I got the unittests running I can take also your idea into
consideration to make it even more feature rich.

At the end we can further discuss it to improve the duplication search. I
prefer to go with my codebase because there I know everything haha.

If you have any recomendations we can also discuss them directly in the MR
it self.

Best regards,
Martin


Mario Frank <[email protected]> schrieb am Di., 21. März 2023, 10:01:

> Darn,
>
> my filters sorted away those mails and I forgot about that topic - sorry
> for that.
> Your Merge Request looks interesting. I had a more or less similar
> solution.
>
> My approach was that I wanted to be able to search between potentially
> distinct
> album sets. So I wanted to be able to select one directory tree as the
> tree in which the reference image lies and another tree where I assume
> duplicates. The aim was also to select images with specific tags as
> reference
> images and search for duplicates in specific albums. So I made it quite
> generic.
> Normally, source albums and target albums are identical. Only when the
> enhanced
> search is activated, the source albums can be specified (screenshots
> appended).
>
> Due to lack of time, the code is sleeping now on my local machine for quite
> some time. I don't even know how long. It is currently in sync with 7.10.
> Getting it in sync with 8.0.0 should be not too time consuming.
> But your approach could be a good/more elegant solution.
>
> Best,
> Mario
>
>
> Am 20.03.23 um 18:13 schrieb Martin Marmsoler:
>
> Hi all,
>
> I am currently working on the duplicate algorithm
> https://invent.kde.org/graphics/digikam/-/merge_requests/202
>
> The code is finished and I am trying to write a few unittests.
> I added a test to database/CMakeLists.txt as follow:
>
> ecm_add_tests(${CMAKE_CURRENT_SOURCE_DIR}/haariface_utest.cpp
>
>               NAME_PREFIX
>
>               "digikam-"
>
>               LINK_LIBRARIES
>
>               digikamcore
>               digikamdatabase
>               digikamgui
>
>               ${COMMON_TEST_LINK}
> )
>
> But now I get a linker error:
> digikam/core/tests/database/haariface_utest.cpp:99: Fehler: undefined
> reference to `Digikam::AlbumSelectors::AlbumSelectors(QString const&,
> QString const&, QWidget*, Digikam::AlbumSelectors::AlbumType)'
>
> AlbumSelectors is in the library "gui_digikamalbum_obj" which gets linked
> to digikamgui.
>
> Is there anybody with a hint what is missing?
>
> BR,
> Martin
>
>
> Am Fr., 20. Jan. 2023 um 12:28 Uhr schrieb Martin Marmsoler <
> [email protected]>:
>
>> Hi all,
>>
>> I got it to build, I just installed the git version of digikam from Aur
>> (arch) and then it worked fine ( the config file was placed at the correct
>> location and creating the database worked also fine).
>> I created just a mr (far away for finish and not yet functional, but I
>> like to track discussions already from begining).
>> https://invent.kde.org/graphics/digikam/-/merge_requests/202
>>
>> But if Mario has already code maybe it makes more sense to merge this
>> instead of my work.
>>
>> @Mario I am waiting to see your approach of implementing something like
>> this.
>>
>> Best regards,
>> Martin
>>
>>
>>
>>
>> Gilles Caulier <[email protected]> schrieb am Fr., 20. Jan. 2023,
>> 11:49:
>>
>>> Hi Martin
>>>
>>> Nice to see you in this room again. We are waiting for your new code
>>> to be reviewed as a merge request.
>>>
>>> All my best
>>>
>>> Gilles
>>>
>>> Le ven. 20 janv. 2023 à 11:36, Mario Frank <[email protected]> a
>>> écrit :
>>> >
>>> > Hi Martin,
>>> >
>>> > I was extremely busy at work the last years and did not have any time
>>> for
>>> > digiKam. But I do have some implementation in my local branch which
>>> > is currently not merged. I could try to get this into digiKam.
>>> > I'll post to the bug today and describe my implementation and discuss
>>> > with the others in which version it should be integrated.
>>> >
>>> > Cheers,
>>> > Mario
>>> >
>>> > Am 19.01.23 um 09:07 schrieb Gilles Caulier:
>>> > > Le mer. 18 janv. 2023 à 17:15, Martin Marmsoler
>>> > > <[email protected]> a écrit :
>>> > >> Is there anybody working on this feature:
>>> https://bugs.kde.org/show_bug.cgi?id=388981
>>> > >> It really annoys me and if nobody took it up I would like to
>>> implement it?
>>> > > Not me. I'm busy on the new documentation :
>>> > >
>>> > > https://docs.digikam.org/en/main_window/similarity_view.html
>>> > >
>>> > > Best
>>> > >
>>> > > Gilles Caulier
>>> > >
>>> > >
>>> > >> Am Mi., 18. Jan. 2023 um 15:36 Uhr schrieb Martin Marmsoler <
>>> [email protected]>:
>>> > >>>
>>> > >>>
>>> > >>> The error message I get is: Could not open the configuration file
>>> <b></b>. This file is installed with the digikam application and is
>>> absolutely required to run digikam. Please check your installation.
>>> > >>>
>>> > >>> BR,
>>> > >>> Martin
>>> > >>>
>>> > >>> Am Mi., 18. Jan. 2023 um 15:24 Uhr schrieb Martin Marmsoler <
>>> [email protected]>:
>>> > >>>> Hi Maik,
>>> > >>>>
>>> > >>>> thanks for the response. I uninstalled digikam for now to not
>>> have those plugins installed. Now it fails during initialization of the
>>> database in main.cpp:
>>> > >>>>
>>> > >>>> AlbumManager::instance()->setDatabase(params,
>>> !commandLineDBPath.isNull(), firstAlbumPath)
>>> > >>>> returns false because of "ScanController::AbortImmediately"
>>> > >>>>
>>> > >>>> Lokale Variablen
>>> > >>>> aboutData @0x7fffffffe1b8 KAboutData
>>> > >>>> app @0x7fffffffe210 QApplication
>>> > >>>> argc 1 int
>>> > >>>> argv <ein Element> char **
>>> > >>>> commandLineDBPath "" QString
>>> > >>>> config @0x7fffffffe1d0 KSharedConfig::Ptr
>>> > >>>> digikam 0x0 Digikam::DigikamApp*
>>> > >>>> firstAlbumPath "" QString
>>> > >>>> group @0x7fffffffe220 KConfigGroup
>>> > >>>> iconTheme "" QString
>>> > >>>> mainConfig @0x7fffffffe230 KConfigGroup
>>> > >>>> params @0x7fffffffe280 Digikam::DbEngineParameters
>>> > >>>> connectOptions "" QString
>>> > >>>> databaseNameCore
>>> "/home/$USER/Dokumente/Festplatte/database/digikam4.db" QString
>>> > >>>> databaseNameFace
>>> "/home/$USER/Dokumente/Festplatte/database/recognition.db" QString
>>> > >>>> databaseNameSimilarity
>>> "/home/$USER/Dokumente/Festplatte/database/similarity.db" QString
>>> > >>>> databaseNameThumbnails
>>> "/home/$USER/Dokumente/Festplatte/database/thumbnails-digikam.db" QString
>>> > >>>> databaseType "QSQLITE" QString
>>> > >>>> hostName "" QString
>>> > >>>> internalServer false bool
>>> > >>>> internalServerDBPath "" QString
>>> > >>>> internalServerMysqlAdminCmd "" QString
>>> > >>>> internalServerMysqlInitCmd "" QString
>>> > >>>> internalServerMysqlServCmd "" QString
>>> > >>>> password "" QString
>>> > >>>> port -1 int
>>> > >>>> userName "" QString
>>> > >>>> walMode false bool
>>> > >>>> parser @0x7fffffffe1c0 QCommandLineParser
>>> > >>>> ret -1076182377 int
>>> > >>>> system @0x7fffffffe200 Digikam::SystemSettings
>>> > >>>> version "8.0.0-beta1" QString
>>> > >>>> Inspector
>>> > >>>> Ausdrücke
>>> > >>>> Rückgabewert
>>> > >>>> Tooltip
>>> > >>>>
>>> > >>>> Best regards,
>>> > >>>> Martin
>>> > >>>>
>>> > >>>> Am Mo., 16. Jan. 2023 um 19:51 Uhr schrieb Maik Qualmann <
>>> [email protected]>:
>>> > >>>>> You still have "old" plugins in the directory. A possible path
>>> is "/usr/lib64/
>>> > >>>>> qt5/plugins/digikam/". Check the files in the folders based on
>>> the date, which
>>> > >>>>> plugins were not last updated and delete them. Due to the API
>>> change (help doc
>>> > >>>>> added), loading the "old" plugins crashes.
>>> > >>>>>
>>> > >>>>> Maik
>>> > >>>>>
>>> > >>>>> Am Montag, 16. Januar 2023, 17:28:35 CET schrieb Martin
>>> Marmsoler:
>>> > >>>>>> Hello,
>>> > >>>>>>
>>> > >>>>>> I am trying currently to debug digikam. So far building worked
>>> fine and
>>> > >>>>>> also debugging works.
>>> > >>>>>> (For setup I used bootstrap.local)
>>> > >>>>>> But when the application opens, it fails with a segmentation
>>> fault:
>>> > >>>>>>
>>> > >>>>>> 3 QString::toUtf8() const &                     qstring.h
>>>      684
>>> > >>>>>> 0x7ffff5e630a2
>>> > >>>>>> 4 KConfigGroup::readEntry<bool>                 kconfiggroup.h
>>>     260
>>> > >>>>>> 0x7ffff5e6331f
>>> > >>>>>> 5 Digikam::DPluginLoader::Private::appendPlugin
>>> dpluginloader_p.cpp 161
>>> > >>>>>> 0x7ffff61f2b8c
>>> > >>>>>> 6 Digikam::DPluginLoader::Private::loadPlugins
>>> dpluginloader_p.cpp 223
>>> > >>>>>> 0x7ffff61f34cb
>>> > >>>>>> 7 Digikam::DPluginLoader::init
>>> dpluginloader.cpp   62
>>> > >>>>>>   0x7ffff61ef768
>>> > >>>>>> 8 Digikam::DigikamApp::DigikamApp               digikamapp.cpp
>>>     137
>>> > >>>>>> 0x7ffff775a811
>>> > >>>>>> 9 main                                          main.cpp
>>>     402
>>> > >>>>>> 0x55555555a712
>>> > >>>>>>
>>> > >>>>>>
>>> > >>>>>> commit id: d3e3a6c2e986bd35e47654824d62345374f67c5e (master
>>> 15.01.2023)
>>> > >>>>>>
>>> > >>>>>> Do you have an idea why it crashes?
>>> > >>>>>>
>>> > >>>>>> BR,
>>> > >>>>>> Martin
>>> > >>>>>
>>> > >>>>>
>>> > >>>>>
>>> >
>>>
>>
>