D27583: rebuild mosaic multiple dataset
Deepak Kumar <[email protected]>
| Newsgroups | gmane.comp.kde.education |
|---|---|
| Message-ID | <[email protected]> |
dekumar added inline comments. INLINE COMMENTS > jjazeix wrote in Mosaic.qml:136 > Ok, I was just checking regarding to the old code where it was: > > property int nbSelectorColumns: horizontal ? > Activity.selectorLayout[nbItems][0] : > Activity.selectorLayout[nbItems][0] / 2 > > so I expected it to be twice the same. > Note that it is about the nbSelectorColumns and the condition is on the layout, it is not related to any row. Yeah, I kept it earlier as with the old code but was getting type error due to that. So, I updated it. Regarding your second comment I would check it again once and update the diff. REPOSITORY R2 GCompris REVISION DETAIL https://phabricator.kde.org/D27583 To: dekumar, #gcompris_improvements, jjazeix, timotheegiet, echarruau Cc: kde-edu, narvaez, apol