D27583: rebuild mosaic multiple dataset

Deepak Kumar <[email protected]> Mon, 9 Mar 2020 19:14:01 +0000

Newsgroups	gmane.comp.kde.education
Message-ID	<[email protected]>

dekumar added inline comments.

INLINE COMMENTS

> jjazeix wrote in Mosaic.qml:70
> it seems to be a string?

It's a typo. I would fixed it.

> jjazeix wrote in Mosaic.qml:145
> why (column.horizontal ? 1 : 1)?

I am making changes to the layout using different states. This issue would be fixed when I shall update the diff.

> jjazeix wrote in Data.qml:33
> it's not intuitive, we don't know what it means or does. Can you rename it?

Yeah, sure. What do you think of renaming is as "multipledataType" ??

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D27583

To: dekumar, #gcompris_improvements, jjazeix, timotheegiet, echarruau
Cc: kde-edu, narvaez, apol