D27994: Improvement in Solar System Hints

Johnny Jazeix <[email protected]>
Newsgroups gmane.comp.kde.education
Message-ID <[email protected]>
jjazeix accepted this revision.
jjazeix added a comment.
This revision is now accepted and ready to land.


  Hi, under which name should I commit? "FirstName LastName <email>" for the syntax :)

INLINE COMMENTS

> SolarSystem.qml:394
> +                else{
> +                    if(items.hintProvided)
> +                        displayDialog(hintDialog)

it should not be needed as we should not display the hint icon if no hint is provided (meaning we can't click on it)

REVISION DETAIL
  https://phabricator.kde.org/D27994

To: anujyadav, #gcompris_improvements, jjazeix
Cc: jjazeix, timotheegiet, kde-edu, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, asagtani, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, scagarwal, apol, bcoudoin
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.