D28456: number Sequence, move config to activity config
Johnny Jazeix <[email protected]>
| Newsgroups | gmane.comp.kde.education |
|---|---|
| Message-ID | <[email protected]> |
jjazeix added inline comments.
INLINE COMMENTS
> number_sequence.js:148
> function won() {
> + items.mode == 1 ? items.bonus.win.connect(nextLevel) : items.bonus.win.disconnect(nextLevel)
> items.bonus.good("flower")
instead of changing it twice in initLevel and in won, would it be better to always connect the signal in Bonus to an internal slot and in this slot, check if mode == 1. If yes, we call Activity.nextLevel?
This way, we don't play with connect/disconnect and the change is only on one place
REPOSITORY
R2 GCompris
REVISION DETAIL
https://phabricator.kde.org/D28456
To: shubhammishra, jjazeix, #gcompris_improvements
Cc: kde-edu, narvaez, apol