D28489: digital electricity, movie config to activityConfig multiple dataset style

Johnny Jazeix <[email protected]>
Newsgroups gmane.comp.kde.education
Message-ID <[email protected]>
jjazeix added inline comments.

INLINE COMMENTS

> ActivityConfig.qml:24
> +import "../../core"
> +import "digital_electricity.js" as Activity
> +

not needed

> DigitalElectricity.qml:118
>              property real zoomLvl: 0.25
> +            property string mode
>          }

it would be better to have it just before the line of isTutorialMode so we group together the related information

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D28489

To: dekumar, jjazeix, #gcompris_improvements
Cc: kde-edu, narvaez, apol
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.