D28689: Hotfixes for the Focus module
Eric Dejouhanet <[email protected]>
| Newsgroups | gmane.comp.kde.education |
|---|---|
| Message-ID | <[email protected]> |
TallFurryMan added a comment. A few things I wanted to add but will delay: - UI does not reflect the use of SEP and Centroid for initial detection, nor for full-field analysis. - Due to the first point, the tests are not properly verifying the Threshold and Gradient algorithms because the full-field analysis option is set! - UI does a weird toggle on the capture button when preparing the screen, and re-enables said button *before* the star extraction completes (that code block is tricky to refactor). - Due to the first point, the tests need to wait an arbitrary duration to verify the detection results. REPOSITORY R321 KStars REVISION DETAIL https://phabricator.kde.org/D28689 To: TallFurryMan, #kstars, mutlaqja Cc: kde-edu, mutlaqja, murveit, narvaez, apol