D29008: Use the mount Pier Side property to manage Pier Flip

Jasem Mutlaq <[email protected]> Wed, 22 Apr 2020 06:00:40 +0000

Newsgroups	gmane.comp.kde.education
Message-ID	<[email protected]>

mutlaqja added inline comments.

INLINE COMMENTS

> TallFurryMan wrote in capture.cpp:6831
> Prototype `char const * Capture::MFStageString(MFStage stage) const` is more appropriate?
> That function has no interest in providing a QString object.
> Also, these strings are used in logs, so you may want to output something more friendly?

Isn't this getting casted to QString? I saw we avoid C strings in the code. Perhaps the only change required here is more friendly names.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D29008

To: chrisrowland, mutlaqja
Cc: TallFurryMan, wreissenberger, kde-edu, narvaez, apol