D29325: Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp)

astrorunner created this revision.
astrorunner added a reviewer: KStars.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
astrorunner requested review of this revision.

REVISION SUMMARY
  Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp)
  Added unit test for bahtinov focus assistent
  Fix compiler error (comparison between int and double)
  Fix compiler error after merge
  
  1. Conflicts:
  2. kstars/fitsviewer/fitsview.cpp

TEST PLAN
  Tested manually by installing software on Raspberry Pi and connect it to my telescope, pointing to a bright star and check if bahtinov mask is overlaying the diffraction pattern correctly.

REPOSITORY
  R321 KStars

BRANCH
  bahtinov-mask-focus-process-review-comments (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29325

AFFECTED FILES
  Tests/fitsviewer/CMakeLists.txt
  Tests/fitsviewer/bahtinov-focus.fits
  Tests/fitsviewer/testfitsdata.cpp
  Tests/fitsviewer/testfitsdata.h
  kstars/CMakeLists.txt
  kstars/ekos/focus/focus.cpp
  kstars/ekos/focus/focus.ui
  kstars/fitsviewer/fitsbahtinovdetector.cpp
  kstars/fitsviewer/fitsbahtinovdetector.h
  kstars/fitsviewer/fitscommon.h
  kstars/fitsviewer/fitsdata.cpp
  kstars/fitsviewer/fitsdata.h
  kstars/fitsviewer/fitsstardetector.h
  kstars/fitsviewer/fitsview.cpp
  kstars/fitsviewer/fitsviewer.cpp
  kstars/fitsviewer/fpackutil.c
  kstars/fitsviewer/hough/houghline.cpp
  kstars/fitsviewer/hough/houghline.h
  kstars/kstars.kcfg

To: astrorunner, #kstars
Cc: kde-edu, narvaez, apol