D29355: Fix issue with Meridian Flip Retry
Chris Rowland <[email protected]> Sat, 2 May 2020 15:21:31 +0000
| Newsgroups | gmane.comp.kde.education |
|---|---|
| Message-ID | <[email protected]> |
chrisrowland added inline comments. INLINE COMMENTS > chrisrowland wrote in mount.cpp:1293-1296 > No issues with doing this, I'd missed that it could take some time before the flip is attempted and fails. > How will this test work if the mount doesn't report pier side? pierside could be PIER_UNKNOWN > From what I can see it will use ha + 12 which is the case for the flip as the mount is crossing the meridian under the pole at about 12h. > Maybe it would be better to check for PIER_EAST and swap the if and else statements. Tried and there doesn't seem to be a problem. The PIER_UNKNOWN case has already been trapped so it can't get here. REPOSITORY R321 KStars REVISION DETAIL https://phabricator.kde.org/D29355 To: murveit, chrisrowland, mutlaqja Cc: kde-edu, narvaez, apol