D29325: Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp)

Patrick Molenaar <[email protected]> Mon, 4 May 2020 11:32:50 +0000
Newsgroups	gmane.comp.kde.education
Message-ID	<[email protected]>
astrorunner added a comment.


  Hi Eric,
  
  The e-mail address for my github and phabricator account are all the same. I have matched my committer and author name to match the phabricator too, but that doesn't seem to work.
  
  Here the result of 'git log --format=full HEAD'
  
  $ git log --format=full HEAD
  commit f75ee7357e1ac3cd7b7cfbf68468d8b5b36f4513 (HEAD -> new_bahtinov_attempt)
  Author: astrorunner <[email protected]>
  Commit: astrorunner <[email protected]>
  
    Fix compiler error (comparison between int and double)
    
    Summary:
    Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp)
    
    Updated copyright information
    
    Added unit test for bahtinov focus assistent
    
    Fix build error
    
    Subscribers: kde-edu
    
    Tags: #kde_edu
    
    Differential Revision: https://phabricator.kde.org/D29364
  
  commit 57682009ba84871f733626a2a1e4ad96fd76fcbb
  Author: astrorunner <[email protected]>
  Commit: astrorunner <[email protected]>
  
    Added unit test for bahtinov focus assistent
  
  commit e60e9050eb5c15e1b58d9f8973c4448ba0c05b9e
  Author: astrorunner <[email protected]>
  Commit: astrorunner <[email protected]>
  
    Updated copyright information
  
  commit bb0532cab26b215219c21b7bd252ceec14bc503c
  Author: astrorunner <[email protected]>
  Commit: astrorunner <[email protected]>
  
    Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp)
  
  commit 343311c4b033e90c06453b3b49caeb50b64aced3
  Author: astrorunner <[email protected]>
  Commit: astrorunner <[email protected]>
  
    Fix compiler error (comparison between int and double)
  
  commit 3d738d3a6ea07d362cdb579c74052b29ab659157 <https://phabricator.kde.org/R321:3d738d3a6ea07d362cdb579c74052b29ab659157> (kde/master, master)
  Author: Hy Murveit <[email protected]>
  Commit: Jasem Mutlaq <[email protected]>
  
    Comment out a couple wordy debug log messages
    
    Test Plan: Check that no code changed, outside of 2 fewer log lines.
    
    Reviewers: mutlaqja, chrisrowland
    
    Reviewed By: mutlaqja
    
    Subscribers: kde-edu
    
    Tags: #kde_edu
    
    Differential Revision: https://phabricator.kde.org/D29317
  
  I see in the logging that I should use my full name as committer and author. I will change the git log (as described in an earlier e-mail) and then commit it again. Hopefully that will solve the issue.
  
  Kind regards,
  
  Patrick
  
  ________________________________
  
  Van: Eric Dejouhanet <[email protected]>
  Verzonden: maandag 4 mei 2020 10:59
  Aan: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
  CC: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
  Onderwerp: D29325 <https://phabricator.kde.org/D29325>: Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp)
  
  View Revisionhttps://phabricator.kde.org/D29325
  TallFurryMan added a comment.
  
  My initial mail was blocked for moderation, sorry for this weird reply:
  
  Patrick, could you share the result of "git log HEAD" (without the patch part, only the header so we see the committer and the author) ?
  My KDE user is "TallFurryMan" but my profile name there is "Eric Dejouhanet". More importantly I think, my email is the same in my commits and in my profile.
  
  REPOSITORY
  R321 <https://phabricator.kde.org/source/kstars/> KStars
  
  BRANCH
  new_bahtinov_attempt (branched from master)
  
  REVISION DETAIL
  https://phabricator.kde.org/D29325
  
  To: astrorunner, KStars, TallFurryMan, mutlaqja
  Cc: lancaster, astrorunner, mutlaqja, TallFurryMan, kde-edu, narvaez, apol

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D29325

To: astrorunner, #kstars, TallFurryMan, mutlaqja
Cc: lancaster, astrorunner, mutlaqja, TallFurryMan, kde-edu, narvaez, apol