Re: dot articles on planet kde
Stuart Jarvis <[email protected]>
| Newsgroups | gmane.comp.kde.events |
|---|---|
| Message-ID | <[email protected]> |
On Thursday 19 August 2010 16:38:04 Jonathan Riddell wrote: > On Sun, Aug 15, 2010 at 07:25:11PM +0100, Stuart Jarvis wrote: > > On Sunday 15 August 2010 14:26:58 Jonathan Riddell wrote: > > > On Thu, Aug 12, 2010 at 11:44:20AM +0100, Stuart Jarvis wrote: > > > > Ok, I had a quick look last night. Within a few constraints this is > > > > very simple. > > > > > > Lovely, I've now updated planetkde.org. Thanks Stuart. > > > > Thanks. Couple of things - there's a better version at > > http://test.asinen.org/planet2.html (shows what you've subscribed too, > > probably friendly to more browsers - however, I should add a couple of > > checks to that) > > I went with the one I could understand easiest. What's the > difference? (I already added feedback in the config to the current one.)> More CSS, less Javascript. It's a bit quicker if you're dealing with a lot of content (we're not really in this case). Also, it hadn't occurred to me to do feedback the way you did by reusing the same classes, planet2 was better suited to the way I was thinking of doing it. Your way works fine though. If there's an intention to add many more options then it would be better to write it a different way getting the javascript to pick up the options from the html as it makes it simpler to maintain. However, if there are no more additions planned then I think the current solution is fine. The only things I would suggest are removing the onDOMContentLoaded from the body tag (that doesn't work, the event listener is in the javascript instead - but keep the onload trigger). In theory, we should also ask the browser if it supports the methods used (and cookies), but adding those is a bit of a hassle for the current script and we never had them before anyway. I think worst case is you click on an option and nothing happens. > > Also, as Thomas suggested, I can add a link to the RSS feed that matches > > the current settings - if multiple feeds will be made available. > > How would you generate those RSS feeds? Would need to be done serverside - i.e. by you using rawdog and it would need to run everytime the feeds are pulled so it could be quite an overhead to deal with all the combinations. Making a link pointing to the right one with javascript is easy enough (probably switch to planet2.html approach though for that). Again, not worth the investment unless there will be multiple feeds. Stu _______________________________________________ This message is from the kde-promo mailing list. Visit https://mail.kde.org/mailman/listinfo/kde-promo to unsubscribe, set digest on or temporarily stop your subscription.