Re: print dialog issue

Alle 01:37, giovedì 4 gennaio 2007, Aurelien Gateau ha scritto:
> Le Mardi 26 Décembre 2006 21:58, Angelo Naselli a écrit :
> > Hi,
> > I was reviewing our code and testing it I saw there are
> > some problems:
> >
> > 1) if keep ratio is enabled and it is the first time,
> >    wxh is 0.0x0.0, I know the ratio is kept, but i don't like it
> >    so the attached patch should solve the problem.
> 
> Sounds good, please commit.
> 
> > 2) if you want to scale the image the setting is saved but not restored,
> >    and since I wrote that code to use it i have to fix it ;)
> >    Anyway that's weird, I cannot understand why, the code seems to be ok,
> > the only way to fix i found is to change the mScale buttonGroupId, for
> > instance with the mFitToPage one in ui file (1<->2) or setting mScale as
> > default. Before doing this change I'd like to hear something more, can
> > anyone test and explain why?
> 
> I do not really understand what you suggest (can you provide a patch?).
> I had a look at the bug with gdb and it seems that setButton() does not select 
> the button (selectedId() returns -1 after it's called).
ehm, already committed a solution  :-$ , that sounds more as a workaround 
but it works, you can check the changes i commited concernig bug #111641.
I added notes on NEWS, don't know if that is the right way to add them, but
it will be easy to fix before releasing ;)
The PrintDialogPage::setOptions seemd to fail on 
opts["app-gwenview-scale"].toInt( &ok ) ok was false but the value into
gwenviewrc was ok (2 - now 3).
I suspect some other problem like that, I saw some new bug reports on
setting not kept...

Welcome back ;)
Angelo

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
Gwenview-general mailing list
Gwenview-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/gwenview-general

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQBFnNylqEs9DA4DquARAuP2AJ9jroMlIrVC6IczYN4j289gSJEADQCgljmg
I1vpQ6Pvm5KhbW5fL09AUew=
=lqvZ
-----END PGP SIGNATURE-----