Re: Full Screen Information

[Seems like this message didn't reach the list, resending]

Le Saturday 12 January 2008 21:20:04 Carles Pina i Estany, vous avez écrit :
> Hello list,
>
> I send my first patch (draft) for Gwenview 2.x.
>
> This adds an editline to configuration dialog and user can write some
> "variables" like %i for ISO, %t for exposure time, etc.
>
> This variables are showed in full screen mode, in a QLabel, in the
> FullScreenWidget (or whatever the name :-) )
>
> I need some help: I'm calling MainWindow::updateFullScreenInformation
> from MainWindow::slotSelectionChanged . I see that filename is always
> correct, but if user change the phpoto "too fast" Exif information is
> not available.

Hello Carles!

Thanks for the patch. I have a few things I would like to see changed in it 
though:

- You should not call updateFullScreenInformation() from 
slotSelectionChanged(). Instead, I suggest you add code like this in 
openDocumentUrl():

	Document::Ptr doc = DocumentFactory::instance()->load(url);
	connect(doc.data(), SIGNAL(metaDataLoaded()),
		SLOT(updateFullScreenInformation()) );

	if (doc->isMetaDataLoaded()) {
		updateFullScreenInformation();
	}

Put this after the call to DocumentView::openUrl(). This way your label will 
be updated whenever the metadata is available

- Revert the changes in fullscreenbar.cpp, they aren't used.

- The metainfo label is not related to the slideshow object, so it should not 
be stored here. The simplest thing for now is to move it to MainWindow (it's 
a bit crowded, but I'll address this later)

- You read ISOSpeedRatings for both iso and focallength.

- The label color should be set in the FullScreenBar css.

Aurélien

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Gwenview-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gwenview-general