Re: Full Screen Information

Hello Aurélien,

On Jan/15/2008, Aurélien Gâteau wrote:

> Le Saturday 12 January 2008 21:20:04 Carles Pina i Estany, vous avez écrit :
> > Hello list,
> >
> > I send my first patch (draft) for Gwenview 2.x.
> >
> > This adds an editline to configuration dialog and user can write some
> > "variables" like %i for ISO, %t for exposure time, etc.
> >
> > This variables are showed in full screen mode, in a QLabel, in the
> > FullScreenWidget (or whatever the name :-) )
> >
> > I need some help: I'm calling MainWindow::updateFullScreenInformation
> > from MainWindow::slotSelectionChanged . I see that filename is always
> > correct, but if user change the phpoto "too fast" Exif information is
> > not available.
> 
> Hello Carles!
> 
> Thanks for the patch. I have a few things I would like to see changed in it 
> though:

I will do these changes, thanks for your help.

> - You should not call updateFullScreenInformation() from 
> slotSelectionChanged(). Instead, I suggest you add code like this in 
> openDocumentUrl():

thanks, this was one big problem, as I said :-)

> - Revert the changes in fullscreenbar.cpp, they aren't used.

ops! ok!

> - The metainfo label is not related to the slideshow object, so it should not 
> be stored here. The simplest thing for now is to move it to MainWindow (it's 
> a bit crowded, but I'll address this later)

I will, no problem.

> - You read ISOSpeedRatings for both iso and focallength.

copy and paste mistake :-)

> - The label color should be set in the FullScreenBar css.

it was in my plan for next iteration

On weekend (or before) I will send these corrections.

Just for curiosity: somebody from here is going to Fosdem?

-- 
Carles Pina i Estany		GPG id: 0x8CBDAE64
	http://pinux.info	Manresa - Barcelona

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/