Re: Thumbnail Bar

Ilya Konkov a écrit :
> Hello.
> 
> Thanks for patch commit.
> 
> If this look doesn't fit, I'll probably make something similar to
> normal thumbnail view with image view background color:
> http://img248.imageshack.us/img248/6408/gwenview26031ae6.png
> And fullscreen mode:
> http://img169.imageshack.us/img169/2835/gwenview26032jm0.png

The new look is great, thanks a lot!

> About copyrights, I just copied header from one of existed file. I've
> added my name now and there are some pieces of your code, so I think
> your copyright should remain.

Yes, sounds correct.

I committed your patch, with a few changes (as usual :-) ):

- Changed the defaultStyleSheet(bool=false) method to a 
setFullScreenMode(bool) method. Optional booleans makes code more 
difficult to read.

- Moved stylesheet configuration of fullscreen thumbnail bar from 
MainWindow to FullScreenContent. I am trying to keep MainWindow from 
getting to big. It's already a bit too fat right now IMO.

- Added a class comment to ProxyStyle to explain why it's here (nice 
trick, BTW).
I may split this class in two in the future: one would be a pure proxy, 
the other would only reimplement what is necessary to achieve the 
desired look. The pure proxy would have its own file, making it easier 
for other widgets to implement different proxy styles.

The only thing which I think could be improved is the look of the 
scrollbar in fullscreen mode. Maybe something similar to Aperture hud 
scrollbars would be nice (see [1]).

Regards,
Aurélien

[1]: 
http://images.apple.com/aperture/features/images/gallery_processing2_20080206.jpg

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace