Re: Bad behaviour with really extreme images

Hello,

> The patch looks ok, except it should return true, IMHO because down
> sampled is ready.
>
I actually didn't consider it as a patch, but just a fix to show where
is the problem, because I didn't know if it was a proper way to handle
invalid size.
With new attached "patch" no asserts or crashes appear for the images.
And I think that setting some default picture for non-loaded
thumbnails is a good idea, because empty one looks weird =(

> Can you add test cases for both images to DocumentTest? Otherwise I am
> sure this bug will come back to bite us again.

I am not sure what did you want me to do exactly, so:
- I've added images to testLoad(), but test passes ok with these
pictures even without fixes and that's explainably, because crashes
appear only with scaled images and thumbnails.

- I've changed testLoadDownSampled() to catch crash with 1x10k.jpg
(with 0.4 zoom it passes well).


--
Ilya Konkov

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/