Re: Bad behaviour with really extreme images
Aurélien Gâteau <[email protected]> Thu, 14 Aug 2008 17:51:21 +0200
| Newsgroups | gmane.comp.kde.gwenview |
|---|---|
| Message-ID | <[email protected]> |
Ilya Konkov wrote: > Hello, > >> The patch looks ok, except it should return true, IMHO because down >> sampled is ready. >> > I actually didn't consider it as a patch, but just a fix to show where > is the problem, because I didn't know if it was a proper way to handle > invalid size. > With new attached "patch" no asserts or crashes appear for the images. > And I think that setting some default picture for non-loaded > thumbnails is a good idea, because empty one looks weird =( Thanks for the patch. I applied it. It still fails for JPEG, but it improves situation with PNG. You will notice I also improved the way test data is defined so that the filename of the image is displayed on error. Aurélien ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/