Re: "Enlarge to fit" button

todd rme <[email protected]> Thu, 25 Mar 2010 13:54:15 -0400
Newsgroups gmane.comp.kde.gwenview
Message-ID <[email protected]>
--0016e64ccb285d7f500482a3bd28
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2010/3/25 Aur=E9lien G=E2teau <[email protected]>:
> On 25/03/2010 00:16, todd rme wrote:
>> I have this working, but I am having trouble submitting the patch to
>> reviewboard. =A0I might be doing something wrong, but it seems to be no
>> different than any other patch I have submitted. =A0Should I send the
>> patch to the mailing list to see if anyone can figure out what is
>> wrong or is there something special I have to do with gwenview and
>> reviewboard?
>
> Great! Please post it here for now. I think the problem you are having
> with reviewboard is that I need to ask someone to set up a "gwenview"
> group on it... will do so.

Alright, it is attached.  It is triggered by pressing and holding on
the "Fit" button.  There should be a triangle or arrow next to the
word "Fit" to indicate this, but it isn't there for some reason
(probably how the button was overloaded) and I don't now how to get it
back, but that is a cosmetic issue that does not affect the actual
functionality.

As for the patch, the patch is accepted by reviewboard but when I try
to view it the site says that there was an error applying the patch.

-Todd

--0016e64ccb285d7f500482a3bd28
Content-Type: text/x-patch; charset=US-ASCII; name="gwenenlarge.diff"
Content-Disposition: attachment; filename="gwenenlarge.diff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g77v3ddq0

SW5kZXg6IEtERS9rZGVncmFwaGljcy9nd2Vudmlldy9saWIvZG9jdW1lbnR2aWV3L2Fic3RyYWN0
ZG9jdW1lbnR2aWV3YWRhcHRlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEtERS9rZGVncmFwaGljcy9nd2Vu
dmlldy9saWIvZG9jdW1lbnR2aWV3L2Fic3RyYWN0ZG9jdW1lbnR2aWV3YWRhcHRlci5oICAgKHJl
dmlzaW9uIDEwMDUxMTkpCisrKyBLREUva2RlZ3JhcGhpY3MvZ3dlbnZpZXcvbGliL2RvY3VtZW50
dmlldy9hYnN0cmFjdGRvY3VtZW50dmlld2FkYXB0ZXIuaCAgICh3b3JraW5nIGNvcHkpCkBAIC02
Niw2ICs2Niw3IEBACiAgICAgICAgdmlydHVhbCBib29sIGNhblpvb20oKSBjb25zdCB7IHJldHVy
biBmYWxzZTsgfQoKICAgICAgICB2aXJ0dWFsIHZvaWQgc2V0Wm9vbVRvRml0KGJvb2wpIHt9Cisg
ICAgdmlydHVhbCB2b2lkIHNldEVubGFyZ2VTbWFsbGVySW1hZ2VzKGJvb2wpIHt9CgogICAgICAg
IHZpcnR1YWwgYm9vbCB6b29tVG9GaXQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQoKSW5kZXg6
IEtERS9rZGVncmFwaGljcy9nd2Vudmlldy9saWIvZG9jdW1lbnR2aWV3L2RvY3VtZW50dmlldy5j
cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gS0RFL2tkZWdyYXBoaWNzL2d3ZW52aWV3L2xpYi9kb2N1bWVudHZp
ZXcvZG9jdW1lbnR2aWV3LmNwcCAgIChyZXZpc2lvbiAxMDU5NTM5KQorKysgS0RFL2tkZWdyYXBo
aWNzL2d3ZW52aWV3L2xpYi9kb2N1bWVudHZpZXcvZG9jdW1lbnR2aWV3LmNwcCAgICh3b3JraW5n
IGNvcHkpCkBAIC00NCw2ICs0NCw3IEBACiAjaW5jbHVkZSA8bGliL2RvY3VtZW50dmlldy9pbWFn
ZXZpZXdhZGFwdGVyLmg+CiAjaW5jbHVkZSA8bGliL2RvY3VtZW50dmlldy9zdmd2aWV3YWRhcHRl
ci5oPgogI2luY2x1ZGUgPGxpYi9kb2N1bWVudHZpZXcvdmlkZW92aWV3YWRhcHRlci5oPgorI2lu
Y2x1ZGUgPGxpYi9nd2Vudmlld2NvbmZpZy5oPgogI2luY2x1ZGUgPGxpYi9taW1ldHlwZXV0aWxz
Lmg+CiAjaW5jbHVkZSA8bGliL3NpZ25hbGJsb2NrZXIuaD4KICNpbmNsdWRlIDxsaWIvc2xpZGVz
aG93Lmg+CkBAIC0xMTcsNiArMTE4LDggQEAKICAgICAgICAgICAgICAgIG1ab29tV2lkZ2V0ID0g
bmV3IFpvb21XaWRnZXQ7CiAgICAgICAgICAgICAgICBRT2JqZWN0Ojpjb25uZWN0KG1ab29tV2lk
Z2V0LCBTSUdOQUwoem9vbUNoYW5nZWQocXJlYWwpKSwKICAgICAgICAgICAgICAgICAgICAgICAg
dGhhdCwgU0xPVChzbG90Wm9vbVdpZGdldENoYW5nZWQocXJlYWwpKSApOworICAgICAgICAgICAg
ICAgIFFPYmplY3Q6OmNvbm5lY3QobVpvb21XaWRnZXQsIFNJR05BTChlbmxhcmdlU21hbGxlcklt
YWdlc0NoYW5nZWQoYm9vbCkpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdGhh
dCwgU0xPVChzbG90RW5sYXJnZVNtYWxsZXJJbWFnZXNDaGFuZ2VkKGJvb2wpKSk7CiAgICAgICAg
fQoKICAgICAgICB2b2lkIHNldHVwWm9vbUFjdGlvbnMoKSB7CkBAIC00NzUsNiArNDc4LDExIEBA
CiAgICAgICAgZC0+c2V0Wm9vbSh6b29tKTsKIH0KCit2b2lkIERvY3VtZW50Vmlldzo6c2xvdEVu
bGFyZ2VTbWFsbGVySW1hZ2VzQ2hhbmdlZChib29sIHZhbHVlKSB7CisgICAgZC0+bUFkYXB0ZXIt
PnNldEVubGFyZ2VTbWFsbGVySW1hZ2VzKHZhbHVlKTsKKyAgICBHd2Vudmlld0NvbmZpZzo6c2V0
RW5sYXJnZVNtYWxsZXJJbWFnZXModmFsdWUpOworfQorCgogYm9vbCBEb2N1bWVudFZpZXc6OmV2
ZW50RmlsdGVyKFFPYmplY3QqLCBRRXZlbnQqIGV2ZW50KSB7CiAgICAgICAgaWYgKGV2ZW50LT50
eXBlKCkgPT0gUUV2ZW50OjpNb3VzZUJ1dHRvblByZXNzKSB7CgoKCkluZGV4OiBLREUva2RlZ3Jh
cGhpY3MvZ3dlbnZpZXcvbGliL2RvY3VtZW50dmlldy9kb2N1bWVudHZpZXcuaAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBLREUva2RlZ3JhcGhpY3MvZ3dlbnZpZXcvbGliL2RvY3VtZW50dmlldy9kb2N1bWVudHZp
ZXcuaCAgIChyZXZpc2lvbiAxMDcxNzAzKQorKysgS0RFL2tkZWdyYXBoaWNzL2d3ZW52aWV3L2xp
Yi9kb2N1bWVudHZpZXcvZG9jdW1lbnR2aWV3LmggICAod29ya2luZyBjb3B5KQpAQCAtOTYsNiAr
OTYsNyBAQAoKICAgICAgICB2b2lkIHNsb3Rab29tQ2hhbmdlZChxcmVhbCk7CiAgICAgICAgdm9p
ZCBzbG90Wm9vbVdpZGdldENoYW5nZWQocXJlYWwpOworICAgIHZvaWQgc2xvdEVubGFyZ2VTbWFs
bGVySW1hZ2VzQ2hhbmdlZChib29sKTsKCgogcHJpdmF0ZToKCgoKCkluZGV4OiBLREUva2RlZ3Jh
cGhpY3MvZ3dlbnZpZXcvbGliL2RvY3VtZW50dmlldy9pbWFnZXZpZXdhZGFwdGVyLmNwcAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBLREUva2RlZ3JhcGhpY3MvZ3dlbnZpZXcvbGliL2RvY3VtZW50dmlldy9pbWFn
ZXZpZXdhZGFwdGVyLmNwcCAgIChyZXZpc2lvbiA5NjU4MzgpCisrKyBLREUva2RlZ3JhcGhpY3Mv
Z3dlbnZpZXcvbGliL2RvY3VtZW50dmlldy9pbWFnZXZpZXdhZGFwdGVyLmNwcCAgICh3b3JraW5n
IGNvcHkpCkBAIC0xMDIsNiArMTAyLDExIEBACiB9CgoKK3ZvaWQgSW1hZ2VWaWV3QWRhcHRlcjo6
c2V0RW5sYXJnZVNtYWxsZXJJbWFnZXMoYm9vbCB2YWx1ZSkgeworICAgICAgICBkLT5tVmlldy0+
c2V0RW5sYXJnZVNtYWxsZXJJbWFnZXModmFsdWUpOworfQorCisKIGJvb2wgSW1hZ2VWaWV3QWRh
cHRlcjo6em9vbVRvRml0KCkgY29uc3QgewogICAgICAgIHJldHVybiBkLT5tVmlldy0+em9vbVRv
Rml0KCk7CiB9CgoKCkluZGV4OiBLREUva2RlZ3JhcGhpY3MvZ3dlbnZpZXcvbGliL2RvY3VtZW50
dmlldy9pbWFnZXZpZXdhZGFwdGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gS0RFL2tkZWdyYXBoaWNzL2d3
ZW52aWV3L2xpYi9kb2N1bWVudHZpZXcvaW1hZ2V2aWV3YWRhcHRlci5oICAgKHJldmlzaW9uIDEw
NzE3MDMpCisrKyBLREUva2RlZ3JhcGhpY3MvZ3dlbnZpZXcvbGliL2RvY3VtZW50dmlldy9pbWFn
ZXZpZXdhZGFwdGVyLmggICAod29ya2luZyBjb3B5KQpAQCAtNDgsNiArNDgsOCBAQAoKICAgICAg
ICB2aXJ0dWFsIHZvaWQgc2V0Wm9vbVRvRml0KGJvb2wpOwoKKyAgICB2aXJ0dWFsIHZvaWQgc2V0
RW5sYXJnZVNtYWxsZXJJbWFnZXMoYm9vbCk7CisKICAgICAgICB2aXJ0dWFsIGJvb2wgem9vbVRv
Rml0KCkgY29uc3Q7CgogICAgICAgIHZpcnR1YWwgcXJlYWwgem9vbSgpIGNvbnN0OwoKCkluZGV4
OiBLREUva2RlZ3JhcGhpY3MvZ3dlbnZpZXcvbGliL2ltYWdldmlldy5oCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IEtERS9rZGVncmFwaGljcy9nd2Vudmlldy9saWIvaW1hZ2V2aWV3LmggICAocmV2aXNpb24gMTA3
MTcwMykKKysrIEtERS9rZGVncmFwaGljcy9nd2Vudmlldy9saWIvaW1hZ2V2aWV3LmggICAod29y
a2luZyBjb3B5KQpAQCAtNjMsOCArNjMsNiBAQAoKICAgICAgICB2b2lkIHNldEFscGhhQmFja2dy
b3VuZENvbG9yKGNvbnN0IFFDb2xvciYgY29sb3IpOwoKLSAgICAgICB2b2lkIHNldEVubGFyZ2VT
bWFsbGVySW1hZ2VzKGJvb2wgdmFsdWUpOwotCiAgICAgICAgdm9pZCBzZXREb2N1bWVudChEb2N1
bWVudDo6UHRyIGRvY3VtZW50KTsKCiAgICAgICAgRG9jdW1lbnQ6OlB0ciBkb2N1bWVudCgpIGNv
bnN0OwpAQCAtMTA0LDYgKzEwMiw3IEBACgogcHVibGljIFFfU0xPVFM6CiAgICAgICAgdm9pZCBz
ZXRab29tVG9GaXQoYm9vbCBvbik7CisgICAgICAgIHZvaWQgc2V0RW5sYXJnZVNtYWxsZXJJbWFn
ZXMoYm9vbCB2YWx1ZSk7CgogcHJvdGVjdGVkOgogICAgICAgIHZpcnR1YWwgdm9pZCBwYWludEV2
ZW50KFFQYWludEV2ZW50Kik7CgoKSW5kZXg6IEtERS9rZGVncmFwaGljcy9nd2Vudmlldy9saWIv
em9vbXdpZGdldC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gS0RFL2tkZWdyYXBoaWNzL2d3ZW52aWV3L2xp
Yi96b29td2lkZ2V0LmNwcCAgIChyZXZpc2lvbiAxMDU5NTM5KQorKysgS0RFL2tkZWdyYXBoaWNz
L2d3ZW52aWV3L2xpYi96b29td2lkZ2V0LmNwcCAgICh3b3JraW5nIGNvcHkpCkBAIC0zMCwxMCAr
MzAsMTMgQEAKICNpbmNsdWRlIDxRTGFiZWw+CiAjaW5jbHVkZSA8UUhCb3hMYXlvdXQ+CiAjaW5j
bHVkZSA8UVNsaWRlcj4KKyNpbmNsdWRlIDxRTWVudT4KCiAvLyBLREUKKyNpbmNsdWRlIDxrbG9j
YWxlLmg+CgogLy8gTG9jYWwKKyNpbmNsdWRlIDxsaWIvZ3dlbnZpZXdjb25maWcuaD4KICNpbmNs
dWRlICJ6b29tc2xpZGVyLmgiCiAjaW5jbHVkZSAic2lnbmFsYmxvY2tlci5oIgogI2luY2x1ZGUg
InN0YXR1c2JhcnRvb2xidXR0b24uaCIKQEAgLTY1LDYgKzY4LDEwIEBACiAgICAgICAgWm9vbVNs
aWRlciogbVpvb21TbGlkZXI7CiAgICAgICAgUUFjdGlvbiogbVpvb21Ub0ZpdEFjdGlvbjsKICAg
ICAgICBRQWN0aW9uKiBtQWN0dWFsU2l6ZUFjdGlvbjsKKyAgICBRTWVudSogbVpvb21Ub0ZpdE1l
bnU7CisgICAgUUFjdGlvbkdyb3VwKiBtWm9vbVRvRml0TW9kZXM7CisgICAgUUFjdGlvbiogbVpv
b21Ub0ZpdFNocmluazsKKyAgICBRQWN0aW9uKiBtWm9vbVRvRml0U2hyaW5rRW5sYXJnZTsKCiAg
ICAgICAgYm9vbCBtWm9vbVVwZGF0ZWRCeVNsaWRlcjsKCkBAIC05OCw2ICsxMDUsMjggQEAKICAg
ICAgICAgICAgICAgIGQtPm1BY3R1YWxTaXplQnV0dG9uLT5zZXRHcm91cFBvc2l0aW9uKFN0YXR1
c0JhclRvb2xCdXR0b246Okdyb3VwTGVmdCk7CiAgICAgICAgICAgICAgICBkLT5tWm9vbVRvRml0
QnV0dG9uLT5zZXRHcm91cFBvc2l0aW9uKFN0YXR1c0JhclRvb2xCdXR0b246Okdyb3VwUmlnaHQp
OwogICAgICAgIH0KKworICAgIGQtPm1ab29tVG9GaXRNZW51ID0gbmV3IFFNZW51KGQtPm1ab29t
VG9GaXRCdXR0b24pOworICAgIGQtPm1ab29tVG9GaXRNb2RlcyA9IG5ldyBRQWN0aW9uR3JvdXAo
ZC0+bVpvb21Ub0ZpdE1lbnUpOworICAgIGQtPm1ab29tVG9GaXRTaHJpbmsgPSBuZXcgUUFjdGlv
bihpMThuKCJTaHJpbmsgdG8gRml0IiksZC0+bVpvb21Ub0ZpdE1vZGVzKTsKKyAgICBkLT5tWm9v
bVRvRml0U2hyaW5rRW5sYXJnZSA9IG5ldyBRQWN0aW9uKGkxOG4oIkVubGFyZ2Ugb3IgU2hyaW5r
IHRvIEZpdCIpLGQtPm1ab29tVG9GaXRNb2Rlcyk7CisgICAgZC0+bVpvb21Ub0ZpdFNocmluay0+
c2V0Q2hlY2thYmxlKHRydWUpOworICAgIGQtPm1ab29tVG9GaXRTaHJpbmtFbmxhcmdlLT5zZXRD
aGVja2FibGUodHJ1ZSk7CisgICAgZC0+bVpvb21Ub0ZpdFNocmluay0+c2V0QXV0b1JlcGVhdChm
YWxzZSk7CisgICAgZC0+bVpvb21Ub0ZpdFNocmlua0VubGFyZ2UtPnNldEF1dG9SZXBlYXQoZmFs
c2UpOworICAgIGQtPm1ab29tVG9GaXRTaHJpbmstPnNldFRvb2xUaXAoaTE4bigiSW1hZ2VzIHdp
bGwgc2hyaW5rIHRvIGZpdCB0aGUgdmlld2luZyBhcmVhIGJ1dCB3aWxsIG5vdCBlbmxhcmdlIikp
OworICAgIGQtPm1ab29tVG9GaXRTaHJpbmtFbmxhcmdlLT5zZXRUb29sVGlwKGkxOG4oIkltYWdl
cyB3aWxsIGVubGFyZ2Ugb3Igc2hyaW5rIHRvIGZpdCB0aGUgdmlld2luZyBhcmVhIikpOworICAg
IGQtPm1ab29tVG9GaXRNZW51LT5hZGRBY3Rpb24oZC0+bVpvb21Ub0ZpdFNocmluayk7CisgICAg
ZC0+bVpvb21Ub0ZpdE1lbnUtPmFkZEFjdGlvbihkLT5tWm9vbVRvRml0U2hyaW5rRW5sYXJnZSk7
CisKKyAgICBib29sIGVubGFyZ2VTbWFsbGVySW1hZ2VzID0gR3dlbnZpZXdDb25maWc6OmVubGFy
Z2VTbWFsbGVySW1hZ2VzKCk7CisKKyAgICBkLT5tWm9vbVRvRml0U2hyaW5rLT5zZXRDaGVja2Vk
KCFlbmxhcmdlU21hbGxlckltYWdlcyk7CisgICAgZC0+bVpvb21Ub0ZpdFNocmlua0VubGFyZ2Ut
PnNldENoZWNrZWQoZW5sYXJnZVNtYWxsZXJJbWFnZXMpOworCisgICAgZC0+bVpvb21Ub0ZpdEJ1
dHRvbi0+c2V0TWVudShkLT5tWm9vbVRvRml0TWVudSk7CisKKyAgICBjb25uZWN0KGQtPm1ab29t
VG9GaXRTaHJpbmtFbmxhcmdlLFNJR05BTCh0b2dnbGVkKGJvb2wpKSx0aGlzLFNJR05BTChlbmxh
cmdlU21hbGxlckltYWdlc0NoYW5nZWQoYm9vbCkpKTsKCiAgICAgICAgZC0+bVpvb21MYWJlbCA9
IG5ldyBRTGFiZWw7CiAgICAgICAgZC0+bVpvb21MYWJlbC0+c2V0Rml4ZWRXaWR0aChkLT5tWm9v
bUxhYmVsLT5mb250TWV0cmljcygpLndpZHRoKCIgMTAwMCUgIikpOwoKCkluZGV4OiBLREUva2Rl
Z3JhcGhpY3MvZ3dlbnZpZXcvbGliL3pvb213aWRnZXQuaAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBLREUva2Rl
Z3JhcGhpY3MvZ3dlbnZpZXcvbGliL3pvb213aWRnZXQuaCAgIChyZXZpc2lvbiAxMDcxNzAzKQor
KysgS0RFL2tkZWdyYXBoaWNzL2d3ZW52aWV3L2xpYi96b29td2lkZ2V0LmggICAod29ya2luZyBj
b3B5KQpAQCAtNTIsNiArNTIsNyBAQAoKIFFfU0lHTkFMUzoKICAgICAgICB2b2lkIHpvb21DaGFu
Z2VkKHFyZWFsKTsKKyAgICAgICAgdm9pZCBlbmxhcmdlU21hbGxlckltYWdlc0NoYW5nZWQoYm9v
bCk7CgogcHJpdmF0ZSBRX1NMT1RTOgogICAgICAgIHZvaWQgc2xvdFpvb21TbGlkZXJSYW5nZUNo
YW5nZWQoKTsKCg==
--0016e64ccb285d7f500482a3bd28
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--0016e64ccb285d7f500482a3bd28
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Gwenview-general mailing list
Gwenview-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/gwenview-general

--0016e64ccb285d7f500482a3bd28--