Re: Review Request: Enable or disable "Enlarge to Fit" from the "Fit" button in the Gwenview statusbar

> On 2010-03-31 22:20:44, Gaurish Sharma wrote:
> > -1 from me.
> > This method is non-standard, sort of custom hack.  all settings would be modified ONLY configration option from menu.
> 
> Todd wrote:
>     If you right click on the Dolphin address bar you can change several options that are also available from the configuration dialog.  Those changes are lost when you start a new session, but if that is your primary criticism I could fix it with a one-line change to this patch.  I was uncertain whether remembering the change across sessions was better or not, but I forgot to mention that in the description (although I did mention it in an earlier email).  I could also make this so it is activated on right-click but that would be a more significant change.
> 
> Gaurish Sharma wrote:
>     My concern is on usability on this, how useful this option will be for Gwenview's Target user group.Because this "menu" to enable or disable "Enlarge to fit" option is like a easter egg which is hidden from user. I am pretty certain, most users won't even know about it. unless they start clicking on every button or holding up for few secs to find out if some magical menu appears.

I agree, which is why it needs the little triangular indicator that most buttons with that capability have.  Unfortunately I do not know how to implement that.  It is supposed to appear automatically but isn't.


- Todd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3452/#review4824
-----------------------------------------------------------


On 2010-03-31 02:56:41, Todd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3452/
> -----------------------------------------------------------
> 
> (Updated 2010-03-31 02:56:41)
> 
> 
> Review request for Gwenview.
> 
> 
> Summary
> -------
> 
> Currently in gwenview in order to disable or disable "Enlarge to fit" you must go to the gwenview configuration screen and enable or disable a checkbox.  This patch adds an additional, much quicker method to accomplish the same goal.  Pressing and holding on the "Fit" button in the statusbar now brings up a menu that allows you to switch between the two modes.  The setting is remembered between sessions and is the same as the one in the configuration dialog, so changing it in one place also changes it in the other.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegraphics/gwenview/lib/documentview/abstractdocumentviewadapter.h 1109333 
>   /trunk/KDE/kdegraphics/gwenview/lib/documentview/documentview.h 1109333 
>   /trunk/KDE/kdegraphics/gwenview/lib/documentview/documentview.cpp 1109333 
>   /trunk/KDE/kdegraphics/gwenview/lib/documentview/imageviewadapter.h 1109333 
>   /trunk/KDE/kdegraphics/gwenview/lib/documentview/imageviewadapter.cpp 1109333 
>   /trunk/KDE/kdegraphics/gwenview/lib/imageview.h 1109333 
>   /trunk/KDE/kdegraphics/gwenview/lib/zoomwidget.h 1109333 
>   /trunk/KDE/kdegraphics/gwenview/lib/zoomwidget.cpp 1109333 
> 
> Diff: http://reviewboard.kde.org/r/3452/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Todd
> 
>


------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev