Re: Review Request: Enable or disable "Enlarge to Fit" from the "Fit" button in the Gwenview statusbar

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3452/
-----------------------------------------------------------

(Updated 2010-04-02 02:34:53.143742)


Review request for Gwenview.


Changes
-------

I've added the standard Qt triangular indicator to show that the button has a menu associated with it.  This makes the button's appearance consistent with other Qt and KDE toolbar buttons with similar menus.


Summary
-------

Currently in gwenview in order to disable or disable "Enlarge to fit" you must go to the gwenview configuration screen and enable or disable a checkbox.  This patch adds an additional, much quicker method to accomplish the same goal.  Pressing and holding on the "Fit" button in the statusbar now brings up a menu that allows you to switch between the two modes.  The setting is remembered between sessions and is the same as the one in the configuration dialog, so changing it in one place also changes it in the other.


Diffs (updated)
-----

  /trunk/KDE/kdegraphics/gwenview/lib/documentview/abstractdocumentviewadapter.h 1109333 
  /trunk/KDE/kdegraphics/gwenview/lib/documentview/documentview.h 1109333 
  /trunk/KDE/kdegraphics/gwenview/lib/documentview/documentview.cpp 1109333 
  /trunk/KDE/kdegraphics/gwenview/lib/documentview/imageviewadapter.h 1109333 
  /trunk/KDE/kdegraphics/gwenview/lib/documentview/imageviewadapter.cpp 1109333 
  /trunk/KDE/kdegraphics/gwenview/lib/imageview.h 1109333 
  /trunk/KDE/kdegraphics/gwenview/lib/statusbartoolbutton.h 1109333 
  /trunk/KDE/kdegraphics/gwenview/lib/statusbartoolbutton.cpp 1109333 
  /trunk/KDE/kdegraphics/gwenview/lib/zoomwidget.h 1109333 
  /trunk/KDE/kdegraphics/gwenview/lib/zoomwidget.cpp 1109333 

Diff: http://reviewboard.kde.org/r/3452/diff


Testing
-------


Thanks,

Todd


------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev