Re: Review Request: Add a "Save As" option to the SaveBar in GwenView

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3828/
-----------------------------------------------------------

(Updated 2010-04-28 18:58:34.972936)


Review request for Gwenview.


Changes
-------

Fixed indentation (was using 4 spaces earlier as per style guides, switched over to using tabs as per edited file)


Summary
-------

Patch aims to add a 'Save As' option to the SaveBar that appears when any kind of change is made to an image.

Simple addition (thanks to existing actionCollection) that activates the "file_save_as" action as it already exists and is visible by the same condition that 'current Url save' action uses.

I find this useful myself particularly -- I never wish my original image to be changed (rotate, crop or etc.), and would like an easier access to the Save As action that I otherwise have to access via the toolbar (if configured) or the File menu. The SaveBar makes it easier to spot, feels at home there since I like using the Toolbar for simple navigation (at which its brilliant!).

Not sure if it actually fixes the associated bug, but seemed relevant (has a fullscreen request but I don't see a SaveBar inside that mode..)

OK to commit?

P.s. I noticed a FIXME regarding use of Q/KAction instead, but I didn't get what to fix -- Should all QToolButtons be changed to use Q/KActions? Point me on the task and I shall gladly try to get it fixed if also required :)


This addresses bug 146095.
    https://bugs.kde.org/show_bug.cgi?id=146095


Diffs (updated)
-----

  /trunk/KDE/kdegraphics/gwenview/app/savebar.cpp 1119657 

Diff: http://reviewboard.kde.org/r/3828/diff


Testing
-------

With single and multiple files changed - works fine, only the requested image is saved after supplying a new name/location via the prompt.


Screenshots
-----------

Save As Toolbutton on the SaveBar
  http://reviewboard.kde.org/r/3828/s/377/


Thanks,

Harsh


------------------------------------------------------------------------------