Re: K3b 1.0.1 eject problem
Sebastian Trüg <[email protected]>
| Newsgroups | gmane.comp.kde.k3b |
|---|---|
| Message-ID | <[email protected]> |
Sorry for the delay. On Saturday 12 May 2007 01:14:35 [email protected] wrote: > With the following change a new DVD+R DL (VIDEO) disk is ejected after the > burn process is completed. > One can quit k3b, but it is still running in the background and "xkill k3b" > doesn't help to finish k3b. Is this without your patch? And does the output from your other mail come from a K3b run with or without your patch? > I don't know if the change has harmful effect on other things during the > burning process. > > --- ./libk3bdevice/k3bdevice.cpp > +++ ./libk3bdevicek3bdevice.cpp > @@ -1677,7 +1677,7 @@ > if( d->openedReadWrite != write ) > close(); > > - d->mutex.lock(); > + //d->mutex.lock(); > > d->openedReadWrite = write; This is very weird. I tried to find the reason but was not able to. Could you please apply the attached patch and reproduce the output from your other mail without your patch. Then I can see if the eject command goes through or not. Cheers, Sebastian ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ K3b-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/k3b-user
devicehandler.diff
(text/x-diff, 872 B)
Index: k3bdevicehandler.cpp
===================================================================
--- k3bdevicehandler.cpp (revision 670854)
+++ k3bdevicehandler.cpp (working copy)
@@ -32,6 +32,8 @@
void run() {
+ kdDebug() << "(K3bDevice::DeviceHandler) starting command: " << command << endl;
+
success = false;
m_bCanceled = false;
@@ -116,6 +118,8 @@
dev->close();
}
+ kdDebug() << "(K3bDevice::DeviceHandler) finished command: " << command << endl;
+
//
// This thread only gets cancelled if a new request was started.
// So we don't emit the finished signal for this (old) request.
@@ -271,8 +275,6 @@
else
jobStarted();
- kdDebug() << "(K3bDevice::DeviceHandler) starting command: " << command << endl;
-
m_thread->command = command;
m_thread->start();
}