Re: "Maintenance" -> "Statistics.." does something completely different

Johannes Zarl-Zierl <[email protected]>
Newsgroups gmane.comp.kde.kimdaba
Message-ID <1784458.lYlFsLI3k5@mani>
Hi Andreas,

Thanks for the report and patch! I've merged it to git master...

Somehow, the accidental removal of the now re-added line slipped code review. 
The button should work fine in older releases of KPhotoAlbum; KPhotoAlbum 5.4 
is affected by this.

  Johannes

Am Sonntag, 25. November 2018, 18:28:27 CET schrieb Andreas Schleth:
> Hi Johannes,
> 
> in the latest few git-master revisions I found a strange menu entry
> below "maintenance":
> 
> "Statistics.."  This led to the dialog "Do you really want to rebuild
> all thumbnails?" - so clearly a misnomer.
> 
> I found the culprit in MainWindow/Window.cpp: The line to call the
> statistics dialog was simply missing.
> 
> Attached please find a patch against today's git-master to re-introduce
> the statistics dialog. It seems to do what it is called.
> 
> However, I do not have the faintest idea what I really did :-)  I just
> copied the line with buildThumbs above and exchanged the appropriate
> strings.
> 
> Could You please check if this makes any sense?
> 
> Andreas
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.