Re: small patch to fix gps search
Johannes Zarl-Zierl <[email protected]> Fri, 15 Nov 2019 00:11:03 +0100
| Newsgroups | gmane.comp.kde.kimdaba |
|---|---|
| Message-ID | <3978035.1pbjm9AdNo@mani> |
Hi Reimar, Good catch, and thanks for the patch! Cheers, Johannes Am Dienstag, 12. November 2019, 22:21:49 CET schrieb Reimar Imhof: > Hi, > > I like the geo position feature in kphotoalbum. > Now I ran in this gps select/search issue: > 1.) Select places, select a place --> all pictures tagged with that place > are selected. That's expected. (Or you could select people or what ever.) > 2.) Go to geo position and select some of the selected pictures by gps > position. --> the selection doesn't change. That's not expected. > > My patch is very simple: > In ImageSearchInfo I've seen a call to > m_matchGeneration = nextGeneration() > every time the search info is changed. As I couldn't find this call to > nextGeneration() when setting the gps region (setRegionSelection(...)), I've > just changed this. > Now I can select pictures by gps position even if I've allready selected by > some categories or even gps positions. > > Please have a look. > > Cheers, > Reimar