Another performance issue
Robert Krawitz <rlk-FrUbXkNCsVf2fBVCVOL8/[email protected]> Sun, 5 Jan 2020 13:07:00 -0500 (EST)
| Newsgroups | gmane.comp.kde.kimdaba |
|---|---|
| Message-ID | <20200105180700.1A7FC423A75@localhost> |
I've determined that DB::FileNameList ThumbnailView::ThumbnailWidget::selection(ThumbnailView::SelectionMode mode) const is being called once per image, and each time it loops over all images currently in the set, so it's quadratic (these lines are >>>in and <<<out, with the incrementing number being the number of times through the loop). kphotoalbum.ThumbnailWidget: >>> ThumbnailWidget::Selection 1 kphotoalbum.ThumbnailWidget: <<< ThumbnailWidget::Selection 3426 0 kphotoalbum.ThumbnailWidget: >>> ThumbnailWidget::Selection 1 kphotoalbum.ThumbnailWidget: <<< ThumbnailWidget::Selection 3427 0 kphotoalbum.ThumbnailWidget: >>> ThumbnailWidget::Selection 1 kphotoalbum.ThumbnailWidget: <<< ThumbnailWidget::Selection 3428 0 kphotoalbum.ThumbnailWidget: >>> ThumbnailWidget::Selection 1 kphotoalbum.ThumbnailWidget: <<< ThumbnailWidget::Selection 3429 0 kphotoalbum.ThumbnailWidget: >>> ThumbnailWidget::Selection 1 kphotoalbum.ThumbnailWidget: <<< ThumbnailWidget::Selection 3430 0 kphotoalbum.ThumbnailWidget: >>> ThumbnailWidget::Selection 1 kphotoalbum.ThumbnailWidget: <<< ThumbnailWidget::Selection 3431 0 -- Robert Krawitz <rlk-FrUbXkNCsVf2fBVCVOL8/[email protected]> *** MIT Engineers A Proud Tradition http://mitathletics.com *** Member of the League for Programming Freedom -- http://ProgFree.org Project lead for Gutenprint -- http://gimp-print.sourceforge.net "Linux doesn't dictate how I work, I dictate how Linux works." --Eric Crampton