Re: Speeding up annotation

On Sun, 05 Jan 2020 21:56:32 +0100, Tobias Leupold wrote:
> Nice :-) It's really cool how you find such performance issues!

Partly it's something I'm interested in, partly I have a very large
database of photos.  But there are still multiple problems in this
area (at least 3 more; this was just the worst).

> But maybe, while you're at it, you want to replace ole Q_FOREACH with a C++11
> for ( : ) loop?

Right now the code's a hodgepods, with 160 Q_FOREACH and about 100
(two different regexps yielded 102 and 103 respectively) for ( : )
loops.  I agree that we want to fix that; the question is do we want
to do it piecemeal or in one shot.

> Am Sonntag, 5. Januar 2020, 20:23:50 CET schrieb Robert Krawitz:
>> I found one easy fix in the selection code after the annotations are
>> changed.  It's still very slow and may be worse than linear, but at
>> least one real problem is cleaned up.
>>
>> Given where we are in the release cycle, I want more review before
>> pushing it.

-- 
Robert Krawitz                                     <rlk-FrUbXkNCsVf2fBVCVOL8/[email protected]>

***  MIT Engineers   A Proud Tradition   http://mitathletics.com  ***
Member of the League for Programming Freedom  --  http://ProgFree.org
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton