Re: Annotation performance improvments
Robert Krawitz <rlk-FrUbXkNCsVf2fBVCVOL8/[email protected]> Tue, 14 Jan 2020 18:36:17 -0500 (EST)
| Newsgroups | gmane.comp.kde.kimdaba |
|---|---|
| Message-ID | <20200114233617.0D0524249B1@localhost> |
On Tue, 14 Jan 2020 23:03:24 +0100, Johannes Zarl-Zierl wrote: > Hi, > > Am Dienstag, 14. Jänner 2020, 01:02:10 CET schrieb Robert Krawitz: >> I've created a new 'annotation-performance' branch with these >> improvements. If everyone agrees that they're safe, I think it would >> be good to get this into 5.6; it will greatly improve performance of >> annotation for people with a lot of images and groups. > > So far, there's three commits: > 252bc62b Improve calculation of max text height > 49a8a47e Improve performance of annotation dialog > b7f378e6 Speed up computing new selection > > The two last ones seem safe on first sight. > The first one (252bc62b) computes consistently too low numbers, leading to clipped text. Returning grps.length() - 1 instead leads to occasional wasted space, but seems otherwise lead to correct results. Interesting. Can you send me a screenshot? -- Robert Krawitz <[email protected]> *** MIT Engineers A Proud Tradition http://mitathletics.com *** Member of the League for Programming Freedom -- http://ProgFree.org Project lead for Gutenprint -- http://gimp-print.sourceforge.net "Linux doesn't dictate how I work, I dictate how Linux works." --Eric Crampton _______________________________________________ KPhotoAlbum mailing list [email protected] https://mail.kdab.com/mailman/listinfo/kphotoalbum