Re: Some minor cleanups
Robert Krawitz <rlk-FrUbXkNCsVf2fBVCVOL8/[email protected]> Tue, 25 Feb 2020 08:30:11 -0500 (EST)
| Newsgroups | gmane.comp.kde.kimdaba |
|---|---|
| Message-ID | <20200225133011.DE173424A56@localhost> |
On Tue, 25 Feb 2020 07:32:19 +0100, Tobias Leupold wrote: >> I haven't changed maps to hashes at this time, but it's worth >> considering. > It definitely is, in each and every case the ordering doesn't matter (at least > imho). > > Same for the Q_FOREACH removal I wanted to do recently. Tell me when your > stuff is merged, so that I can redo it. I've merged everything but the change from maps to hashes, so you can redo it. Maps vs. hashes is all localized in one place in DB/ImageInfo.h, and shouldn't collide with what you're doing. The parallel-md5 branch doesn't appear to contain any Q_FOREACHes. My repo's in flux right now since I started the merge last night, or I would have done it myself. > Nice, the codebase gets cleaner and cleaner :-) Yes, this is a significant cleanup. -- Robert Krawitz <rlk-FrUbXkNCsVf2fBVCVOL8/[email protected]> *** MIT Engineers A Proud Tradition http://mitathletics.com *** Member of the League for Programming Freedom -- http://ProgFree.org Project lead for Gutenprint -- http://gimp-print.sourceforge.net "Linux doesn't dictate how I work, I dictate how Linux works." --Eric Crampton