Re: newToOldCategory in Database.cpp

On 10/11/20 2:24 AM, Tobias Leupold wrote:
> Iirc, we needed this back then when we kicked out the localized categories.
> 
> The original behavior was that e. g. "Locations" was passed through the
> translations mechanism and was displayed as e. g. "Orte" with a German locale
> (being actually called "Locations" though). This caused a lot of problems
> later on, so we decided to initialize the category names once in the currently
> used locale when the database is created and use this very name also in the
> database.
> 
> As no l10n has been done anymore later on, a German speaking user would have
> seen "Locations" on-screen (the actual name) instead of the localized "Orte",
> so we had to move those category names once to their localized counterpart.
> 
> It's been some years, but I think this code would still be needed if a quite
> old database was loaded with a recent version.

OK, it just doesn't appear to me that this code is actually used.

(FYI, I'm rather less optimistic about this change, given something else I tried last night that
didn't show the gain I hoped.)