Re: Proposal: KDE CVS Commit Policy

On Sunday 30 March 2003 17:47, Neil Stevens wrote:
> On Sunday March 30, 2003 07:43, Stephan Binner wrote:
> > On Sunday 30 March 2003 14:24, Cornelius Schumacher wrote:
> > >  6. Make sure that the maintainer of the code you are changing
> > > knows about your plans before committing.
> >
> > Do you want to describe the current situation (above has nothing to
> > do with reality) or do you want to change and slow down the
> > development? Most of my commits would be illegal by this
> > definition. What about dead maintainers?
>
> How about this:
>
> 6. Respect the policies of application and library maintainers, and
> consult with them before making large changes.  Source control
> systems are not a substitute for developer communication.

That's a good point, but it's not exactly what I was trying to say. My 
point was that changes which affect a lot of code in CVS (e.g. making 
use of a new feature in the libs, like the replacement of 
QString::replace(QRegExp) by QString::replace(QString) or using 
KMainWindow::createStandardStatusBarAction() ) should be announced in 
advance, so that developers are prepared for these changes and can 
express concerns before something gets broken.

I will add your point to the list, clarify my point and send a new 
version shortly.

-- 
Cornelius Schumacher <[email protected]>