How much ifdeffing?

As an indication of how much fiddling around there is right now to support 
Solaris, I grepped the codebase; it's really not that bad, although we can 
see it is handled rather inconsistently. All of these could probably stand 
re-examination with our current platform choices (nv_64 or later, Studio 12, 
Cstd), and definitely they could be made more consistent. The test for 
HAVE_ISINF needs fixing up, that will tidy operations.cpp.

./kioslave/http/kcookiejar/kcookiejar.cpp:#ifdef USE_SOLARIS
./kio/kio/kservicegroup.cpp:#ifndef USE_SOLARIS
./kio/kio/kmountpoint.cpp:#ifdef _OS_SOLARIS_
./kio/kio/kmountpoint.cpp:#ifdef _OS_SOLARIS_
./kio/kio/kmountpoint.cpp:#ifdef _OS_SOLARIS_
./kio/misc/kpac/script.cpp:#ifdef __SUNPRO_CC
./kdecore/network/k3resolver.cpp:#  ifdef Q_OS_SOLARIS // Solaris uses a 4 
argument getprotobynumber_r which returns struct *protoent or NULL
./kdecore/network/k3resolver.cpp:#  ifdef Q_OS_SOLARIS // Solaris uses a 4 
argument getprotobyname_r which returns struct *protoent or NULL
./kdecore/network/k3resolver.cpp:#  ifdef Q_OS_SOLARIS // Solaris uses a 4 
argument getprotobyname_r which returns struct *protoent or NULL
./kdecore/network/k3resolver.cpp:#  ifdef Q_OS_SOLARIS // Solaris uses a 5 
argument getservbyname_r which returns struct *servent or NULL
./kdecore/network/k3resolver.cpp:#  ifdef Q_OS_SOLARIS // Solaris uses a 5 
argument getservbyname_r which returns struct *servent or NULL
./kdecore/network/k3resolver.cpp:#  ifdef Q_OS_SOLARIS // Solaris uses a 5 
argument getservbyport_r which returns struct *servent or NULL
./kdecore/sycoca/ksycoca.cpp:#ifdef Q_OS_SOLARIS
./kjs/math_object.cpp:#if PLATFORM(SOLARIS_OS)
./kjs/collector.cpp:#if PLATFORM(SOLARIS_OS)
./kjs/lookup.h:#if COMPILER(SUNPRO)
./kjs/lookup.h:#if COMPILER(SUNPRO)
./kjs/lookup.h:#if COMPILER(SUNPRO)
./kjs/operations.cpp:#elif HAVE(FUNC_ISINF) && !PLATFORM(SOLARIS_OS)
./kjs/operations.cpp:#elif HAVE(FUNC_ISINF) && !PLATFORM(SOLARIS_OS)
./kjs/operations.cpp:#elif HAVE(FUNC_ISINF) && !PLATFORM(SOLARIS_OS)
./kjs/wtf/HashSet.h:#if COMPILER(SUNPRO)
./kjs/wtf/HashSet.h:#if COMPILER(SUNPRO)
./kjs/wtf/HashTraits.h:#if PLATFORM(SOLARIS_OS)
./kjs/wtf/HashMap.h:#if COMPILER(SUNPRO)
./kjs/wtf/Platform.h:/* PLATFORM(SOLARIS_OS)
./kjs/wtf/Platform.h:#if defined(__SUNPRO_CC)
./kjs/wtf/Platform.h:#define WTF_PLATFORM_SOLARIS_OS 1
./kjs/wtf/Platform.h:/* COMPILER(SUNPRO) */
./kjs/wtf/Platform.h:#if defined(__SUNPRO_CC)
./kjs/wtf/Platform.h:#define WTF_COMPILER_SUNPRO 1
./kdeprint/cups/cupsdconf2/cupsdconf.cpp:               t << "PrintcapFormat " 
<< (printcapformat_ == PRINTCAP_SOLARIS ? "Solaris" : "BSD") << endl;
./kdeprint/cups/cupsdconf2/cupsdconf.cpp:       else if (keyword 
== "printcapformat") printcapformat_ = (value.toLower() == "solaris" ? 
PRINTCAP_SOLARIS : PRINTCAP_BSD);
./kdeprint/cups/cupsdconf2/cupsdserverpage.cpp: 
printcapformat_->addItem("SOLARIS");
./kdeprint/cups/cupsdconf2/cupsdconf.h:enum PrintcapFormatType { PRINTCAP_BSD 
= 0, PRINTCAP_SOLARIS };
./kioslave/file/file.cpp:#if defined(__svr4__) && defined(__sun__) // MARCO 
for Solaris 8 and I
./kdecore/localization/gettext.h:#if defined(__sun)
./kdecore/io/kpty.cpp:#ifdef __sun


-- 
These are your friends - Adem
    GPG: FEA2 A3FE Adriaan de Groot

___________________________________________________
This message is from the kde-solaris mailing list.
Account management:  https://mail.kde.org/mailman/listinfo/kde-solaris.
Archives: http://lists.kde.org/.
More info: http://www.kde.org/faq.html.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)

iD8DBQBGyuNKdqzuAf6io/4RArGaAJ9pO1DNlSHDFInGwVeHbmGBEdwLJQCgj1H0
bSprMVXnMXCf24hCKfPeLnM=
=nCDq
-----END PGP SIGNATURE-----