Re: [KDE Usability] Review Request 128052: Improve agenda view in digital-clock applet

Daniel Vrátil <[email protected]>
Newsgroups gmane.comp.kde.usability,gmane.comp.kde.devel.plasma
Message-ID <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128052/
-----------------------------------------------------------

(Updated June 9, 2016, 1:03 a.m.)


Review request for Plasma, KDE Usability, Martin Klapetek, and Thomas Pfeiffer.


Changes
-------

* fix alignment
* don't use year in event start/end date, makes the field way too long on some locales (e.g. cs_CZ where time is HH:mm and date dd.MM.YYYY)
* use Inactive palette for the event summary and end date text color, because Disabled palette is almost invisible in light Breeze theme


Repository: plasma-workspace


Description
-------

I've been working on CalendarEventsPlugin for the digital-clock applet to show events from Akonadi, but it turned out the agenda view in the applet is not really ready to show real-world events yet, so I played around with it for a while this evening...it's nothing fancy, but at least I feel like I can use the agenda view productively now. See screenshots below.


Diffs (updated)
-----

  applets/digital-clock/package/contents/ui/CalendarView.qml fb30c6f 

Diff: https://git.reviewboard.kde.org/r/128052/diff/


Testing
-------


File Attachments
----------------

Agenda view - before
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/583a3955-76bc-4e3b-8bc2-053c269acf22__calendar-before.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/316644c5-4184-4b6c-bf5f-a86cf25fa5db__calendar1.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/810cb0db-5844-486f-bee9-722a0299e943__calendar2.png
Agenda view - before
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/e73f7249-4ed3-4283-94d2-e92e412262b3__calendar-before.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/966381cf-4a0b-4adc-a68b-ddb9110a9527__calendar1.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/64ddc24b-be06-405e-88f6-868a4bf0f687__calendar2.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/30/5b2cabb7-71dd-4cb4-9054-43426e9c6b14__calendar1.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/30/463fc403-3ffb-4cd4-8a6c-a8bf067db09f__calendar2.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/43f3af18-162b-4600-95ab-b57dd3d98927__calendar1.png
Agenda view - after
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/63be822d-17b9-4a6a-8630-29a40bae65b6__calendar2.png


Thanks,

Daniel Vrátil

_______________________________________________
kde-usability mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-usability
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.